This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Interfaces need to used add_mlir_library
ClosedPublic

Authored by stephenneuendorffer on Mar 19 2020, 4:44 PM.

Download Raw Diff

Details

Reviewers: None
Commits: rG6bc775a1fc1b: [MLIR] Interfaces need to used add_mlir_library

Summary

The Interface libraries were moved from Analysis, but declared in
cmake using add_llvm_library(). This breaks LLVM_BUILD_LLVM_DYLIB
builds.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

stephenneuendorffer created this revision.Mar 19 2020, 4:44 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 19 2020, 4:44 PM

Herald added subscribers: llvm-commits, Joonsoo, liufengdb and 12 others. · View Herald Transcript

This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2020, 5:00 PM

Closed by commit rG6bc775a1fc1b: [MLIR] Interfaces need to used add_mlir_library (authored by stephenneuendorffer). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B49814: Diff 251502.Mar 19 2020, 6:40 PM

Revision Contents

Path

Size

mlir/

lib/

Interfaces/

CMakeLists.txt

12 lines

Diff 251509

mlir/lib/Interfaces/CMakeLists.txt

	set(LLVM_OPTIONAL_SOURCES			set(LLVM_OPTIONAL_SOURCES
	CallInterfaces.cpp			CallInterfaces.cpp
	ControlFlowInterfaces.cpp			ControlFlowInterfaces.cpp
	DerivedAttributeOpInterface.cpp			DerivedAttributeOpInterface.cpp
	InferTypeOpInterface.cpp			InferTypeOpInterface.cpp
	LoopLikeInterface.cpp			LoopLikeInterface.cpp
	SideEffects.cpp			SideEffects.cpp
	)			)

	add_llvm_library(MLIRCallInterfaces			add_mlir_library(MLIRCallInterfaces
	CallInterfaces.cpp			CallInterfaces.cpp

	ADDITIONAL_HEADER_DIRS			ADDITIONAL_HEADER_DIRS
	${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces			${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
	)			)
	add_dependencies(MLIRCallInterfaces			add_dependencies(MLIRCallInterfaces
	MLIRCallInterfacesIncGen			MLIRCallInterfacesIncGen
	)			)
	target_link_libraries(MLIRCallInterfaces			target_link_libraries(MLIRCallInterfaces
	PUBLIC			PUBLIC
	MLIRIR			MLIRIR
	)			)

	add_llvm_library(MLIRControlFlowInterfaces			add_mlir_library(MLIRControlFlowInterfaces
	ControlFlowInterfaces.cpp			ControlFlowInterfaces.cpp

	ADDITIONAL_HEADER_DIRS			ADDITIONAL_HEADER_DIRS
	${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces			${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
	)			)
	add_dependencies(MLIRControlFlowInterfaces			add_dependencies(MLIRControlFlowInterfaces
	MLIRControlFlowInterfacesIncGen			MLIRControlFlowInterfacesIncGen
	)			)
	target_link_libraries(MLIRControlFlowInterfaces			target_link_libraries(MLIRControlFlowInterfaces
	PUBLIC			PUBLIC
	MLIRIR			MLIRIR
	)			)

	add_llvm_library(MLIRDerivedAttributeOpInterface			add_mlir_library(MLIRDerivedAttributeOpInterface
	DerivedAttributeOpInterface.cpp			DerivedAttributeOpInterface.cpp

	ADDITIONAL_HEADER_DIRS			ADDITIONAL_HEADER_DIRS
	${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces			${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
	)			)
	add_dependencies(MLIRDerivedAttributeOpInterface			add_dependencies(MLIRDerivedAttributeOpInterface
	MLIRDerivedAttributeOpInterfaceIncGen			MLIRDerivedAttributeOpInterfaceIncGen
	)			)
	target_link_libraries(MLIRDerivedAttributeOpInterface			target_link_libraries(MLIRDerivedAttributeOpInterface
	PUBLIC			PUBLIC
	MLIRIR			MLIRIR
	)			)

	add_llvm_library(MLIRInferTypeOpInterface			add_mlir_library(MLIRInferTypeOpInterface
	InferTypeOpInterface.cpp			InferTypeOpInterface.cpp

	ADDITIONAL_HEADER_DIRS			ADDITIONAL_HEADER_DIRS
	${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces			${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
	)			)
	add_dependencies(MLIRInferTypeOpInterface			add_dependencies(MLIRInferTypeOpInterface
	MLIRInferTypeOpInterfaceIncGen			MLIRInferTypeOpInterfaceIncGen
	)			)
	target_link_libraries(MLIRInferTypeOpInterface			target_link_libraries(MLIRInferTypeOpInterface
	PUBLIC			PUBLIC
	MLIRIR			MLIRIR
	)			)

	add_llvm_library(MLIRLoopLikeInterface			add_mlir_library(MLIRLoopLikeInterface
	LoopLikeInterface.cpp			LoopLikeInterface.cpp

	ADDITIONAL_HEADER_DIRS			ADDITIONAL_HEADER_DIRS
	${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces			${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
	)			)
	add_dependencies(MLIRLoopLikeInterface			add_dependencies(MLIRLoopLikeInterface
	MLIRLoopLikeInterfaceIncGen			MLIRLoopLikeInterfaceIncGen
	)			)
	target_link_libraries(MLIRLoopLikeInterface			target_link_libraries(MLIRLoopLikeInterface
	PUBLIC			PUBLIC
	MLIRIR			MLIRIR
	)			)

	add_llvm_library(MLIRSideEffects			add_mlir_library(MLIRSideEffects
	SideEffects.cpp			SideEffects.cpp

	ADDITIONAL_HEADER_DIRS			ADDITIONAL_HEADER_DIRS
	${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces			${MLIR_MAIN_INCLUDE_DIR}/mlir/Interfaces
	)			)
	add_dependencies(MLIRSideEffects			add_dependencies(MLIRSideEffects
	MLIRSideEffectOpInterfacesIncGen			MLIRSideEffectOpInterfacesIncGen
	)			)
	target_link_libraries(MLIRSideEffects			target_link_libraries(MLIRSideEffects
	PUBLIC			PUBLIC
	MLIRIR			MLIRIR
	)			)