Add customer step to non-asan buildbot to run make check. These tests from AOR are meant to act as regression tests until AORs are merged into libc.
Tested locally.
Differential D76331
[libc builder] Add custom step for AOR tests. PaulkaToast on Mar 17 2020, 2:54 PM. Authored by
Details
Add customer step to non-asan buildbot to run make check. These tests from AOR are meant to act as regression tests until AORs are merged into libc. Tested locally.
Diff Detail
Event Timeline
|
A high level comment is, annotated_builder.AnnotatedBuilder is very strange as it stands today. It is essentially serving as a namespace as it is stateless. So, mixing and and matching functionality from there and from utils makes it even more strange. I would rather see us moving away from AnnotatedBuilder and building our own libc specific utility here.