Page MenuHomePhabricator

[lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles
ClosedPublic

Authored by jankratochvil on Mar 17 2020, 1:16 PM.

Details

Summary

D63643 added these testfiles but some of the %t4dwo and %t5dwo builds are the same as corresponding %t4 and %t5 builds.
Fortunately the testcases do PASS.

Diff Detail

Event Timeline

jankratochvil created this revision.Mar 17 2020, 1:16 PM
jankratochvil edited the summary of this revision. (Show Details)

With the former patch these both skeleton files:

tools/lldb/test/SymbolFile/DWARF/Output/debug-types-expressions.test.tmp4dwo
tools/lldb/test/SymbolFile/DWARF/Output/debug-types-expressions.test.tmp5dwo

were referencing to this one non-skeleton file:

tools/lldb/test/SymbolFile/DWARF/debug-types-expressions.dwo

Surprisingly it does not affect the other test debug-types-basic.test probably because it compiles to .o and then links it. While debug-types-expressions.test compiles directly to an executable.
So fixed that while keeping the direct executable compilation.

labath accepted this revision.Mar 18 2020, 5:59 AM

Thanks for catching that.

This revision is now accepted and ready to land.Mar 18 2020, 5:59 AM
This revision was automatically updated to reflect the committed changes.