This is an archive of the discontinued LLVM Phabricator instance.

Differential D76217

[obj2yaml][test] - Remove excessive missing_symtab.test test.
ClosedPublic

Authored by grimar on Mar 16 2020, 2:17 AM.

Details

Reviewers
jhenderson
MaskRay
arichardson
Commits
rG00952000351c: [obj2yaml][test] - Remove excessive missing_symtab.test test.
Summary

This test uses a precompiled object and duplicates
the functionality of a modern elf-no-symtab.yaml test that
uses yaml2obj for producing inputs.

Diff Detail

Event Timeline

grimar created this revision.Mar 16 2020, 2:17 AM
grimar retitled this revision from [obj2yaml] - Remove excessive missing_symtab.test test. to [obj2yaml][test] - Remove excessive missing_symtab.test test..
grimar added a reviewer: arichardson.Mar 16 2020, 2:20 AM

The test was added initially in rL313970

MaskRay accepted this revision.Mar 16 2020, 9:11 AM
This revision is now accepted and ready to land.Mar 16 2020, 9:11 AM
jhenderson accepted this revision.Mar 17 2020, 2:30 AM

LGTM.

Closed by commit rG00952000351c: [obj2yaml][test] - Remove excessive missing_symtab.test test. (authored by grimar). · Explain WhyMar 17 2020, 3:00 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2020, 3:00 AM

Revision Contents

PathSize
llvm/
test/
tools/
obj2yaml/
Inputs/

Diff 250710

llvm/test/tools/obj2yaml/Inputs/crt1.o

  • This binary file was deleted.
PropertyOld ValueNew Value
File Mode100755null

llvm/test/tools/obj2yaml/missing_symtab.test

  • This file was deleted.
# RUN: obj2yaml %S/Inputs/crt1.o | FileCheck %s
# test that we don't crash when passed object files without a symbol table
# CHECK-LABEL: FileHeader:
# CHECK-LABEL: Sections:
# CHECK-NOT: Symbols: