This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame
ClosedPublic

Authored by anton.kolesov on Mar 11 2020, 2:27 AM.

Details

Summary

Commit [1] added a declaration of function-member
StackFrame::BehavesLikeZerothFrame but hasn't added an implementation
for the function. This commit removes this declation, because the
function is not used anywhere.

[1] 31e6dbe1c6a6 Fix PC adjustment in StackFrame::GetSymbolContext

Diff Detail

Event Timeline

anton.kolesov created this revision.Mar 11 2020, 2:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2020, 2:27 AM
labath added a subscriber: labath.Mar 11 2020, 4:35 AM

If it's not used anywhere, maybe we should delete it instead?

anton.kolesov retitled this revision from [lldb] Implement StackFrame::BehavesLikeZerothFrame to [lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame.
anton.kolesov edited the summary of this revision. (Show Details)

Removed function declaration as requested.

labath accepted this revision.Mar 12 2020, 4:53 AM
This revision is now accepted and ready to land.Mar 12 2020, 4:53 AM
This revision was automatically updated to reflect the committed changes.