Page MenuHomePhabricator

anton.kolesov (Anton Kolesov)
Manager at Synopsys

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2019, 4:48 AM (64 w, 4 d)

Developing debugging solutions for Synopsys ARC processors.

Recent Activity

Tue, Mar 24

anton.kolesov updated the diff for D76593: [lldb-vscode] Convert launch_info and attach_info to local variables.

Added attach_info conversion into the same revision.

Tue, Mar 24, 11:25 PM · Restricted Project

Mon, Mar 23

anton.kolesov added a comment to D76593: [lldb-vscode] Convert launch_info and attach_info to local variables.

Sounds like a good idea. Could you do the same for attach_info (it looks like it should be possible)? Otherwise, one is left wondering about what's the difference...

Mon, Mar 23, 7:03 AM · Restricted Project
anton.kolesov created D76593: [lldb-vscode] Convert launch_info and attach_info to local variables.
Mon, Mar 23, 2:10 AM · Restricted Project

Wed, Mar 18

anton.kolesov created D76351: [lldb-vscode] Don't use SBLaunchInfo in request_attach.
Wed, Mar 18, 3:46 AM · Restricted Project

Fri, Mar 13

anton.kolesov updated the summary of D75975: [lldb] Copy m_behaves_like_zeroth_frame on stack frame update.
Fri, Mar 13, 6:55 AM · Restricted Project

Thu, Mar 12

anton.kolesov updated the diff for D75979: [lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame.

Removed function declaration as requested.

Thu, Mar 12, 1:36 AM · Restricted Project

Wed, Mar 11

anton.kolesov created D75979: [lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame.
Wed, Mar 11, 3:03 AM · Restricted Project
anton.kolesov created D75975: [lldb] Copy m_behaves_like_zeroth_frame on stack frame update.
Wed, Mar 11, 12:52 AM · Restricted Project

Feb 12 2020

anton.kolesov updated the diff for D70847: [lldb-vscode] Ensure that target matches the executable file.

Updated in attempt to reduce amount of code duplication between request_attach and request_launch.
Built and tested with testsuite on Linux/x64, also built and manually tested on Windows/x64 host with a baremetal ARC cpu target.

Feb 12 2020, 6:31 AM · Restricted Project

Feb 11 2020

anton.kolesov updated the diff for D70847: [lldb-vscode] Ensure that target matches the executable file.

Reverted to the original idea of modifying lldb-vscode. Unlike first version, this commit also modifies request_attach to have the same behaviour. Two new properties are added to request arguments: "targetTriple" and "platformName" to specify values to respective arguments of SBDebugger::CreateTarget().

Feb 11 2020, 5:17 AM · Restricted Project

Feb 2 2020

anton.kolesov added a comment to D70847: [lldb-vscode] Ensure that target matches the executable file.

My original patch was changing lldb-vscode - it was creating a new Target object with ELF given to a constructor. That patch, though definitely would need an update - it should delete the original empty target after creating the new one, but it was leaving it alive. To me this solution looks preferable, because I'm a fanboy for immutable objects in general, and in this specific case I don't fully understand all of the potential side effects of the SetExecutable call.

Feb 2 2020, 10:55 PM · Restricted Project

Jan 31 2020

anton.kolesov added inline comments to D70847: [lldb-vscode] Ensure that target matches the executable file.
Jan 31 2020, 4:41 AM · Restricted Project
anton.kolesov added inline comments to D70847: [lldb-vscode] Ensure that target matches the executable file.
Jan 31 2020, 12:46 AM · Restricted Project

Jan 27 2020

anton.kolesov updated the diff for D70847: [lldb-vscode] Ensure that target matches the executable file.

Added a testcase. Because target's architecture is not directly exposed through an API, test looks at the target triplet - it is empty for targets created without an exe file. Without the patch, triplet remains unchanged after adding an executable, but with the patch, it changes to the architecture of the executable file, whichever it is.

Jan 27 2020, 5:11 AM · Restricted Project

Jan 20 2020

anton.kolesov added a comment to D70847: [lldb-vscode] Ensure that target matches the executable file.

Ping.

Jan 20 2020, 4:35 AM · Restricted Project

Dec 6 2019

anton.kolesov updated the diff for D70847: [lldb-vscode] Ensure that target matches the executable file.

Reimplement the solution based on a comment from Greg.

Dec 6 2019, 2:57 AM · Restricted Project

Dec 3 2019

anton.kolesov added a comment to D70847: [lldb-vscode] Ensure that target matches the executable file.

This needs a test case, though judging by your description it looks like pretty much every test case on affected platforms (I guess, windows) should hit this. Can you check if any of the existing vscode tests which are marked @skipIfWindows start passing now?

Dec 3 2019, 1:28 AM · Restricted Project

Nov 29 2019

anton.kolesov created D70847: [lldb-vscode] Ensure that target matches the executable file.
Nov 29 2019, 3:30 AM · Restricted Project

Apr 29 2019

anton.kolesov updated the diff for D59015: [lldb-mi] Include full path in the -data-disassemble response.

Allocate path buffer on stack instead of heap.

Apr 29 2019, 8:31 AM · Restricted Project, Restricted Project

Apr 26 2019

anton.kolesov added inline comments to D59015: [lldb-mi] Include full path in the -data-disassemble response.
Apr 26 2019, 6:04 AM · Restricted Project, Restricted Project

Apr 22 2019

anton.kolesov added inline comments to D59015: [lldb-mi] Include full path in the -data-disassemble response.
Apr 22 2019, 3:47 AM · Restricted Project, Restricted Project

Apr 16 2019

anton.kolesov added inline comments to D59015: [lldb-mi] Include full path in the -data-disassemble response.
Apr 16 2019, 7:47 AM · Restricted Project, Restricted Project

Apr 9 2019

anton.kolesov updated the diff for D59015: [lldb-mi] Include full path in the -data-disassemble response.

Replaced static local variable (as can be found in CMICmnLLDBDebugSessionInfo::GetFrameInfo) with a unique_ptr to the char array (as done in CMICmnLLDBDebuggerHandleEvents::MiHelpGetModuleInfo).

Apr 9 2019, 12:09 PM · Restricted Project, Restricted Project

Apr 5 2019

anton.kolesov updated the diff for D59015: [lldb-mi] Include full path in the -data-disassemble response.

Added a simple test case.

Apr 5 2019, 7:03 AM · Restricted Project, Restricted Project

Mar 6 2019

anton.kolesov updated the summary of D59015: [lldb-mi] Include full path in the -data-disassemble response.
Mar 6 2019, 1:52 AM · Restricted Project, Restricted Project
anton.kolesov created D59015: [lldb-mi] Include full path in the -data-disassemble response.
Mar 6 2019, 1:51 AM · Restricted Project, Restricted Project

Jan 10 2019

Herald added a reviewer for D55827: Update current working directory to avoid test crashes: serge-sans-paille.
Jan 10 2019, 4:49 AM · Restricted Project