This is an archive of the discontinued LLVM Phabricator instance.

Differential D75970

Fix compiler warning when compiling without asserts
ClosedPublic

Authored by rathod-sahaab on Mar 10 2020, 7:21 PM.

Details

Reviewers
jdoerfert
Commits
rG263c4a3c75a4: Fix compiler warning when compiling without asserts
Summary

This patch aims to prevent warning-as-error failures in release build.
As suggested in this comment
https://reviews.llvm.org/D69930#1910922

Diff Detail

Event Timeline

rathod-sahaab created this revision.Mar 10 2020, 7:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2020, 7:21 PM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
jdoerfert accepted this revision.Mar 10 2020, 7:59 PM

LGTM

This revision is now accepted and ready to land.Mar 10 2020, 7:59 PM
Harbormaster completed remote builds in B48772: Diff 249542.Mar 10 2020, 8:14 PM
jdoerfert mentioned this in D69930: [OpenMP] Introduce the OpenMPOpt transformation pass.Mar 12 2020, 10:34 PM
Closed by commit rG263c4a3c75a4: Fix compiler warning when compiling without asserts (authored by rathod-sahaab, committed by jdoerfert). · Explain WhyMar 12 2020, 10:36 PM
This revision was automatically updated to reflect the committed changes.
xiaoqing_wu added a subscriber: xiaoqing_wu.Mar 13 2020, 2:07 PM

Thanks!

Revision Contents

PathSize
llvm/
lib/
Transforms/
IPO/
2 lines

Diff 250128

llvm/lib/Transforms/IPO/OpenMPOpt.cpp

Show All 38 Lines
STATISTIC(NumOpenMPRuntimeCallsDeduplicated, STATISTIC(NumOpenMPRuntimeCallsDeduplicated,
"Number of OpenMP runtime calls deduplicated"); "Number of OpenMP runtime calls deduplicated");
STATISTIC(NumOpenMPRuntimeFunctionsIdentified, STATISTIC(NumOpenMPRuntimeFunctionsIdentified,
"Number of OpenMP runtime functions identified"); "Number of OpenMP runtime functions identified");
STATISTIC(NumOpenMPRuntimeFunctionUsesIdentified, STATISTIC(NumOpenMPRuntimeFunctionUsesIdentified,
"Number of OpenMP runtime function uses identified"); "Number of OpenMP runtime function uses identified");
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) #if !defined(NDEBUG)
static constexpr auto TAG = "[" DEBUG_TYPE "]"; static constexpr auto TAG = "[" DEBUG_TYPE "]";
#endif #endif
namespace { namespace {
struct OpenMPOpt { struct OpenMPOpt {
OpenMPOpt(SmallPtrSetImpl<Function *> &SCC, OpenMPOpt(SmallPtrSetImpl<Function *> &SCC,
SmallPtrSetImpl<Function *> &ModuleSlice, SmallPtrSetImpl<Function *> &ModuleSlice,
▲ Show 20 Lines • Show All 502 Lines • Show Last 20 Lines