Page MenuHomePhabricator

[LIBOMPTARGET]Fix PR45139: Bug in mixing Python and OpenMP target offload.
ClosedPublic

Authored by ABataev on Mar 10 2020, 10:33 AM.

Details

Summary

Explicitly initialize data members of RTLsTy class upon construction.

Diff Detail

Event Timeline

ABataev created this revision.Mar 10 2020, 10:33 AM
Herald added a project: Restricted Project. · View Herald Transcript
ABataev updated this revision to Diff 249472.Mar 10 2020, 12:28 PM

Initialize all fields by default and use default constructor.

ABataev retitled this revision from [LIBOMPTARGET][WIP]Fix PR45139: Bug in mixing Python and OpenMP target offload. to [LIBOMPTARGET]Fix PR45139: Bug in mixing Python and OpenMP target offload..Mar 10 2020, 12:28 PM
ABataev added a reviewer: grokos.
ABataev added subscribers: kkwli0, caomhin.
ABataev updated this revision to Diff 249473.Mar 10 2020, 12:33 PM

Initialize LibraryHandler field.

grokos accepted this revision.Mar 10 2020, 3:02 PM

I, too, can confirm that this patch fixes the problem. It seems we need to think more about how libomptarget is initialized to avoid similar problems in the future.

This revision is now accepted and ready to land.Mar 10 2020, 3:02 PM
This revision was automatically updated to reflect the committed changes.