This is an archive of the discontinued LLVM Phabricator instance.

[PGO][PGSO] Use IsColdXNthPercentile for sample PGO.
ClosedPublic

Authored by hjyamauchi on Mar 3 2020, 11:15 AM.

Details

Summary

This performs better for sample PGO.
NFC as PGSOColdCodeOnlyForSamplePGO is still true.

Diff Detail

Event Timeline

hjyamauchi created this revision.Mar 3 2020, 11:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2020, 11:15 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
davidxl added inline comments.Mar 3 2020, 4:04 PM
llvm/include/llvm/Transforms/Utils/SizeOpts.h
65

Can you add some comments here about the logic difference?

93

comment here too

hjyamauchi updated this revision to Diff 248214.Mar 4 2020, 9:31 AM
hjyamauchi marked 2 inline comments as done.

Address comment.

davidxl accepted this revision.Mar 4 2020, 12:33 PM

lgtm (please also clang-format the change).

This revision is now accepted and ready to land.Mar 4 2020, 12:33 PM
hjyamauchi updated this revision to Diff 248518.Mar 5 2020, 9:37 AM

Applied clang format.

This revision was automatically updated to reflect the committed changes.