[lldb] Fix that a crashing test is marked as unsupported when it prints UNSUPPORTED before crashing

[teemperor]

Summary

I added an abort() call to some code and noticed that the test suite was still passing and it just marked my test as "UNSUPPORTED".

It seems the reason for that is that we expect failing tests to print "FAIL:" which doesn't happen when we crash. If we then also
have an unsupported because we skipped some debug information in the output, we just mark the test passing because it is unsupported
on the current platform.

This patch marks any test that has a non-zero exit code as failing even if it doesn't print "FAIL:" (e.g., because it crashed).

[labath]

I think this is the right thing to do, but let's also see what Jonas says about it.

Also, this has the potential to mark some tests as failures even though there were previously "passing", so be ready to handle (probably, disable) those...

[aprantl]

Nice.

[JDevlieghere]

I don't remember why this was written this way, maybe there was a good reason for it but probably it was just a mistake. Let's see what happens when we land this :-)

lldb/test/API/lldbtest.py

def execute(self, test, litConfig):
             output += """Command Output (stdout):\n--\n%s\n--\n""" % (out,)
         if err:
             output += """Command Output (stderr):\n--\n%s\n--\n""" % (err,)
 
         if timeoutInfo:
             return lit.Test.TIMEOUT, output
 
         if exitCode:
-            # Match FAIL but not XFAIL.
-            for line in out.splitlines() + err.splitlines():
-                if line.startswith('FAIL:'):
-                    return lit.Test.FAIL, output
-
             if 'XPASS:' in out or 'XPASS:' in err:
                 return lit.Test.XPASS, output
 
+            # Otherwise this is just a failure.
+            return lit.Test.FAIL, output
+
         has_unsupported_tests = 'UNSUPPORTED:' in out or 'UNSUPPORTED:' in err
         has_passing_tests = 'PASS:' in out or 'PASS:' in err
         if has_unsupported_tests and not has_passing_tests:
             return lit.Test.UNSUPPORTED, output
 
         passing_test_line = 'RESULT: PASSED'
         if passing_test_line not in out and passing_test_line not in err:
             return lit.Test.UNRESOLVED, output
 
         return lit.Test.PASS, output