Page MenuHomePhabricator

Fix nullptr access
AcceptedPublic

Authored by vivekvpandya on Feb 23 2020, 6:32 AM.

Details

Summary

[GlobalISel]
Do not pass nullptr in MachineOptimizationRemark constructor, as MBB pointer is used in DiagnosticInfoMIROptimization constructor and that results in nullptr access.

Diff Detail

Event Timeline

vivekvpandya created this revision.Feb 23 2020, 6:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2020, 6:32 AM
Herald added a subscriber: hiraditya. · View Herald Transcript

Testcase? Also typo in message

vivekvpandya edited the summary of this revision. (Show Details)Feb 24 2020, 7:39 AM

Testcase? Also typo in message

I discovered this while creating basic blocks in custom instruction selection for a downstream back-end. I don't know how to write that scenario in a test.

arsenm accepted this revision.Mar 23 2020, 11:53 AM
This revision is now accepted and ready to land.Mar 23 2020, 11:53 AM