Page MenuHomePhabricator

PR21000: pass -I options to assembler
ClosedPublic

Authored by tra on Feb 6 2015, 11:19 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

tra updated this revision to Diff 19500.Feb 6 2015, 11:19 AM
tra retitled this revision from to PR21000: pass -I options to assembler.
tra updated this object.
tra edited the test plan for this revision. (Show Details)
tra added a reviewer: echristo.
tra added a subscriber: Unknown Object (MLST).
tra updated this revision to Diff 19501.Feb 6 2015, 11:29 AM

Moved test cases into a separate file.

echristo edited edge metadata.Feb 6 2015, 11:30 AM

To fix the bug need to make sure -I is passed to both the assembler and integrated assembler?

-eric

tra added a comment.Feb 6 2015, 11:58 AM

To fix the bug need to make sure -I is passed to both the assembler and integrated assembler?

Yes. Neither way we invoke assembler had -I passed to it and thus .include was failing in both cases.

echristo accepted this revision.Feb 6 2015, 2:33 PM
echristo edited edge metadata.

Ah, right. Much better (or I missed that you were testing -no-integrated-as earlier).

-eric

This revision is now accepted and ready to land.Feb 6 2015, 2:33 PM
This revision was automatically updated to reflect the committed changes.