Page MenuHomePhabricator

Fix evaluation commands (MI)
ClosedPublic

Authored by ki.stfu on Feb 6 2015, 3:45 AM.

Details

Summary

These changes include:

  • Fix -var-create to be able use current frame '*' (MI)
  • Fix print-values option in -var-update (MI)
  • Fix 'variable doesn't exist' error in -var-show-attributes (MI)
  • Mark print-values option as 'handled-by-cmd' in -var-update (MI)
  • Fix SBValue::GetValueDidChange if value was changed
  • Fix lldb-mi: -data-evaluate-expression shows undef vars. Before this fix -data-evaluate-expression perceives undefined variables as strings:
(gdb)
-data-evaluate-expression undef
^done,value="undef"
  • Minor fix: -data-evaluate-expression uses IsUnknownValue()
  • Enable MiEvaluateTestCase test

All test pass on OS X.

Diff Detail

Event Timeline

ki.stfu updated this revision to Diff 19473.Feb 6 2015, 3:45 AM
ki.stfu retitled this revision from to Fix evaluation commands (MI).
ki.stfu updated this object.
ki.stfu edited the test plan for this revision. (Show Details)
ki.stfu added reviewers: abidh, clayborg.
ki.stfu added subscribers: abidh, clayborg, Unknown Object (MLST).
ki.stfu updated this object.Feb 6 2015, 3:50 AM
ki.stfu set the repository for this revision to rL LLVM.
clayborg edited edge metadata.Feb 6 2015, 9:38 AM

Looks good

This revision was automatically updated to reflect the committed changes.