This is an archive of the discontinued LLVM Phabricator instance.

[NFC][AggressiveInstCombine] Remove redundant std::max.
ClosedPublic

Authored by aymanmus on Feb 12 2020, 3:42 AM.

Reviewers: None
Commits: rG49a4d85f6d24: [NFC][AggressiveInstCombine] Remove redundant std::max.

Summary

Remove unnecessary std::max call.
LGTM granted in D72837

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2020, 3:55 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Transforms/

AggressiveInstCombine/

2 lines

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Lines	while (!Worklist.empty()) {
for (auto *Operand : Operands)		for (auto *Operand : Operands)
if (auto *IOp = dyn_cast<Instruction>(Operand)) {		if (auto *IOp = dyn_cast<Instruction>(Operand)) {
// If we already calculated the minimum bit-width for this valid		// If we already calculated the minimum bit-width for this valid
// bit-width, or for a smaller valid bit-width, then just keep the		// bit-width, or for a smaller valid bit-width, then just keep the
// answer we already calculated.		// answer we already calculated.
unsigned IOpBitwidth = InstInfoMap.lookup(IOp).ValidBitWidth;		unsigned IOpBitwidth = InstInfoMap.lookup(IOp).ValidBitWidth;
if (IOpBitwidth >= ValidBitWidth)		if (IOpBitwidth >= ValidBitWidth)
continue;		continue;
InstInfoMap[IOp].ValidBitWidth = std::max(ValidBitWidth, IOpBitwidth);		InstInfoMap[IOp].ValidBitWidth = ValidBitWidth;
Worklist.push_back(IOp);		Worklist.push_back(IOp);
}		}
}		}
unsigned MinBitWidth = InstInfoMap.lookup(cast<Instruction>(Src)).MinBitWidth;		unsigned MinBitWidth = InstInfoMap.lookup(cast<Instruction>(Src)).MinBitWidth;
assert(MinBitWidth >= TruncBitWidth);		assert(MinBitWidth >= TruncBitWidth);

if (MinBitWidth > TruncBitWidth) {		if (MinBitWidth > TruncBitWidth) {
// In this case reducing expression with vector type might generate a new		// In this case reducing expression with vector type might generate a new
▲ Show 20 Lines • Show All 212 Lines • Show Last 20 Lines