Page MenuHomePhabricator

scudo: Fix various test failures, mostly on 32-bit.
ClosedPublic

Authored by pcc on Feb 11 2020, 11:29 AM.

Diff Detail

Unit TestsFailed

TimeTest
10 msLLVM.Bindings/Go::go.test
Script: -- : 'RUN: at line 1'; llvm-go test llvm.org/llvm/bindings/go/llvm

Event Timeline

pcc created this revision.Feb 11 2020, 11:29 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 11 2020, 11:29 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
cryptoad accepted this revision.Feb 11 2020, 11:43 AM
cryptoad added inline comments.
compiler-rt/lib/scudo/standalone/size_class_map.h
27

Isn't that still true?

This revision is now accepted and ready to land.Feb 11 2020, 11:43 AM
pcc marked an inline comment as done.Feb 11 2020, 12:16 PM
pcc added inline comments.
compiler-rt/lib/scudo/standalone/size_class_map.h
27

Yes and we're now checking it in the derived classes since this class doesn't know the value of MaxSize.

This revision was automatically updated to reflect the committed changes.