Page MenuHomePhabricator

Fix SFINAE in llvm::bit_cast.
AbandonedPublic

Authored by jlebar on Feb 10 2020, 8:19 PM.

Details

Reviewers
None
Summary

As far as I can tell, the SFINAE was broken; there is no such thing as
std::is_trivially_constructible<T>::type.

Event Timeline

jlebar created this revision.Feb 10 2020, 8:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2020, 8:19 PM

Hm, thank you, arc, for including files that were not in my commit...

jlebar updated this revision to Diff 243724.Feb 10 2020, 8:23 PM

Attempt to remove files which shouldn't be in here.

jlebar abandoned this revision.Feb 10 2020, 8:24 PM

arc is not cooperating; I'm going to delete this and create a new review. Sorry for the noise.

Harbormaster completed remote builds in B46167: Diff 243724.