Page MenuHomePhabricator

[clang-format] Improve handling of C# attributes
ClosedPublic

Authored by jbcoe on Feb 7 2020, 4:12 PM.

Details

Summary

C# attributes can appear on classes and methods, in which case they should go on their own line, or on method parameters in which case
they should be left inline.

Diff Detail

Event Timeline

jbcoe created this revision.Feb 7 2020, 4:12 PM
jbcoe marked an inline comment as done.
jbcoe added inline comments.
clang/lib/Format/TokenAnnotator.cpp
3283

I removed this as it's too aggressive and introduces line breaks when attributes appear on method parameters.

MyDeveloperDay accepted this revision.Feb 9 2020, 8:47 AM

LGTM, thanks

This revision is now accepted and ready to land.Feb 9 2020, 8:47 AM
krasimir accepted this revision.Feb 11 2020, 3:32 AM
Closed by commit rGb46f925d68d4: [clang-format] Improve handling of C# attributes (authored by Jonathan Coe <jbcoe@google.com>). · Explain WhyFeb 11 2020, 4:03 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2020, 4:03 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript