This is an archive of the discontinued LLVM Phabricator instance.

Force an unknown target for the default case to make it work.
ClosedPublic

Authored by filcab on Feb 4 2015, 5:42 PM.

Details

Summary

This test was failing if LLVM_DEFAULT_TARGET_TRIPLE=x86_64-scei-ps4 due to
its behavior for exceptions.
Force an --unknown triple for the default case.

Diff Detail

Event Timeline

filcab updated this revision to Diff 19366.Feb 4 2015, 5:42 PM
filcab retitled this revision from to Force an unknown target for the default case to make it work..
filcab updated this object.
filcab edited the test plan for this revision. (Show Details)
filcab added a reviewer: echristo.
filcab added a subscriber: Unknown Object (MLST).
chandlerc accepted this revision.Feb 5 2015, 10:08 AM
chandlerc added a reviewer: chandlerc.
chandlerc added a subscriber: chandlerc.

Looks good with a less overly specific comment (see below)

test/Driver/clang-exception-flags.cpp
1–3

I would just say that the default behavior of exception handling in target specific.

This revision is now accepted and ready to land.Feb 5 2015, 10:08 AM
This revision was automatically updated to reflect the committed changes.