This is an archive of the discontinued LLVM Phabricator instance.

Differential D74073

[PGO][PGSO] Enable profile guided size optimization for non-cold code under instrumentation PGO.
ClosedPublic

Authored by hjyamauchi on Feb 5 2020, 10:13 AM.

Details

Reviewers
davidxl
Commits
rG4ed205c816e9: [PGO][PGSO] Enable profile guided size optimization for non-cold code under…
Summary

This enables it for large working set size cases only.

This does not enable it under sample PGO.

Diff Detail

Event Timeline

hjyamauchi created this revision.Feb 5 2020, 10:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2020, 10:13 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
Harbormaster completed remote builds in B45787: Diff 242681.Feb 5 2020, 10:15 AM
davidxl accepted this revision.Feb 5 2020, 1:53 PM

lgtm

This revision is now accepted and ready to land.Feb 5 2020, 1:53 PM
Closed by commit rG4ed205c816e9: [PGO][PGSO] Enable profile guided size optimization for non-cold code under… (authored by hjyamauchi). · Explain WhyFeb 6 2020, 10:30 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Transforms/
Utils/
4 lines

Diff 242681

llvm/lib/Transforms/Utils/SizeOpts.cpp

Show All 18 Linescl::opt<bool> EnablePGSO(
cl::desc("Enable the profile guided size optimizations. ")); cl::desc("Enable the profile guided size optimizations. "));
cl::opt<bool> PGSOLargeWorkingSetSizeOnly( cl::opt<bool> PGSOLargeWorkingSetSizeOnly(
"pgso-lwss-only", cl::Hidden, cl::init(true), "pgso-lwss-only", cl::Hidden, cl::init(true),
cl::desc("Apply the profile guided size optimizations only " cl::desc("Apply the profile guided size optimizations only "
"if the working set size is large (except for cold code.)")); "if the working set size is large (except for cold code.)"));
cl::opt<bool> PGSOColdCodeOnly( cl::opt<bool> PGSOColdCodeOnly(
"pgso-cold-code-only", cl::Hidden, cl::init(true), "pgso-cold-code-only", cl::Hidden, cl::init(false),
cl::desc("Apply the profile guided size optimizations only " cl::desc("Apply the profile guided size optimizations only "
"to cold code.")); "to cold code."));
cl::opt<bool> PGSOColdCodeOnlyForInstrPGO( cl::opt<bool> PGSOColdCodeOnlyForInstrPGO(
"pgso-cold-code-only-for-instr-pgo", cl::Hidden, cl::init(true), "pgso-cold-code-only-for-instr-pgo", cl::Hidden, cl::init(false),
cl::desc("Apply the profile guided size optimizations only " cl::desc("Apply the profile guided size optimizations only "
"to cold code under instrumentation PGO.")); "to cold code under instrumentation PGO."));
cl::opt<bool> PGSOColdCodeOnlyForSamplePGO( cl::opt<bool> PGSOColdCodeOnlyForSamplePGO(
"pgso-cold-code-only-for-sample-pgo", cl::Hidden, cl::init(true), "pgso-cold-code-only-for-sample-pgo", cl::Hidden, cl::init(true),
cl::desc("Apply the profile guided size optimizations only " cl::desc("Apply the profile guided size optimizations only "
"to cold code under sample PGO.")); "to cold code under sample PGO."));
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines