This is an archive of the discontinued LLVM Phabricator instance.

Differential D73911

[AVR] Add disassembly tests for supported instructions
ClosedPublic

Authored by aykevl on Feb 3 2020, 11:17 AM.

Details

Reviewers
dylanmckay
thakis
Commits
rGea8b2cb9bf5e: [AVR] Add disassembly tests for supported instructions
Summary

The disassembler of the AVR backend is incomplete: most instructions do not correctly disassemble yet.

This patch is the first in a series to add disassembly support to the AVR backend. It starts with adding disassembler tests for instructions that already disassemble correctly.

Diff Detail

Event Timeline

aykevl created this revision.Feb 3 2020, 11:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2020, 11:17 AM
Herald added a subscriber: Jim. · View Herald Transcript
aykevl mentioned this in D73969: [LLDB] Let DataExtractor deal with two-byte addresses.Feb 4 2020, 8:00 AM
dylanmckay accepted this revision.Feb 4 2020, 9:29 PM

Nice work, thanks for the patch @aykevl!

This revision is now accepted and ready to land.Feb 4 2020, 9:29 PM
Closed by commit rGea8b2cb9bf5e: [AVR] Add disassembly tests for supported instructions (authored by aykevl). · Explain WhyFeb 5 2020, 3:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
MC/
AVR/
3 lines
6 lines
3 lines
3 lines
35 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines

Diff 242550

llvm/test/MC/AVR/inst-break.s

; RUN: llvm-mc -triple avr -mattr=break -show-encoding < %s | FileCheck %s ; RUN: llvm-mc -triple avr -mattr=break -show-encoding < %s | FileCheck %s
; RUN: llvm-mc -filetype=obj -triple avr -mattr=break < %s | llvm-objdump -d -mattr=break - | FileCheck -check-prefix=CHECK-INST %s
foo: foo:
break break
; CHECK: break ; encoding: [0x98,0x95] ; CHECK: break ; encoding: [0x98,0x95]
; CHECK-INST: break

llvm/test/MC/AVR/inst-des.s

; RUN: llvm-mc -triple avr -mattr=des -show-encoding < %s | FileCheck %s ; RUN: llvm-mc -triple avr -mattr=des -show-encoding < %s | FileCheck %s
; RUN: llvm-mc -filetype=obj -triple avr -mattr=des < %s | llvm-objdump -d -mattr=des - | FileCheck -check-prefix=CHECK-INST %s
foo: foo:
des 0 des 0
des 6 des 6
des 1 des 1
des 8 des 8
; CHECK: des 0 ; encoding: [0x0b,0x94] ; CHECK: des 0 ; encoding: [0x0b,0x94]
; CHECK: des 6 ; encoding: [0x6b,0x94] ; CHECK: des 6 ; encoding: [0x6b,0x94]
; CHECK: des 1 ; encoding: [0x1b,0x94] ; CHECK: des 1 ; encoding: [0x1b,0x94]
; CHECK: des 8 ; encoding: [0x8b,0x94] ; CHECK: des 8 ; encoding: [0x8b,0x94]
; CHECK-INST: des 0
; CHECK-INST: des 6
; CHECK-INST: des 1
; CHECK-INST: des 8

llvm/test/MC/AVR/inst-eicall.s

; RUN: llvm-mc -triple avr -mattr=eijmpcall -show-encoding < %s | FileCheck %s ; RUN: llvm-mc -triple avr -mattr=eijmpcall -show-encoding < %s | FileCheck %s
; RUN: llvm-mc -filetype=obj -triple avr -mattr=eijmpcall < %s | llvm-objdump -d -mattr=eijmpcall - | FileCheck -check-prefix=CHECK-INST %s
foo: foo:
eicall eicall
; CHECK: eicall ; encoding: [0x19,0x95] ; CHECK: eicall ; encoding: [0x19,0x95]
; CHECK-INST: eicall

llvm/test/MC/AVR/inst-eijmp.s

; RUN: llvm-mc -triple avr -mattr=eijmpcall -show-encoding < %s | FileCheck %s ; RUN: llvm-mc -triple avr -mattr=eijmpcall -show-encoding < %s | FileCheck %s
; RUN: llvm-mc -filetype=obj -triple avr -mattr=eijmpcall < %s | llvm-objdump -d -mattr=eijmpcall - | FileCheck -check-prefix=CHECK-INST %s
foo: foo:
eijmp eijmp
; CHECK: eijmp ; encoding: [0x19,0x94] ; CHECK: eijmp ; encoding: [0x19,0x94]
; CHECK-INST: eijmp

llvm/test/MC/AVR/inst-family-set-clr-flag.s

; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s ; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s
; RUN: llvm-mc -filetype=obj -triple avr < %s | llvm-objdump -d - | FileCheck -check-prefix=CHECK-INST %s
foo: foo:
; Flag set operations ; Flag set operations
; SEC ; SEC
bset 0 bset 0
sec sec
▲ Show 20 Lines • Show All 88 Lines • ▼ Show 20 Lines
; CHECK: cls ; encoding: [0xc8,0x94] ; CHECK: cls ; encoding: [0xc8,0x94]
; CHECK: cls ; encoding: [0xc8,0x94] ; CHECK: cls ; encoding: [0xc8,0x94]
; CHECK: clh ; encoding: [0xd8,0x94] ; CHECK: clh ; encoding: [0xd8,0x94]
; CHECK: clh ; encoding: [0xd8,0x94] ; CHECK: clh ; encoding: [0xd8,0x94]
; CHECK: clt ; encoding: [0xe8,0x94] ; CHECK: clt ; encoding: [0xe8,0x94]
; CHECK: clt ; encoding: [0xe8,0x94] ; CHECK: clt ; encoding: [0xe8,0x94]
; CHECK: cli ; encoding: [0xf8,0x94] ; CHECK: cli ; encoding: [0xf8,0x94]
; CHECK: cli ; encoding: [0xf8,0x94] ; CHECK: cli ; encoding: [0xf8,0x94]
; CHECK-INST: sec
; CHECK-INST: sec
; CHECK-INST: sez
; CHECK-INST: sez
; CHECK-INST: sen
; CHECK-INST: sen
; CHECK-INST: sev
; CHECK-INST: sev
; CHECK-INST: ses
; CHECK-INST: ses
; CHECK-INST: seh
; CHECK-INST: seh
; CHECK-INST: set
; CHECK-INST: set
; CHECK-INST: sei
; CHECK-INST: sei
; CHECK-INST: clc
; CHECK-INST: clc
; CHECK-INST: clz
; CHECK-INST: clz
; CHECK-INST: cln
; CHECK-INST: cln
; CHECK-INST: clv
; CHECK-INST: clv
; CHECK-INST: cls
; CHECK-INST: cls
; CHECK-INST: clh
; CHECK-INST: clh
; CHECK-INST: clt
; CHECK-INST: clt
; CHECK-INST: cli
; CHECK-INST: cli

llvm/test/MC/AVR/inst-icall.s

; RUN: llvm-mc -triple avr -mattr=ijmpcall -show-encoding < %s | FileCheck %s ; RUN: llvm-mc -triple avr -mattr=ijmpcall -show-encoding < %s | FileCheck %s
; RUN: llvm-mc -filetype=obj -triple avr -mattr=ijmpcall < %s | llvm-objdump -d -mattr=ijmpcall - | FileCheck -check-prefix=CHECK-INST %s
foo: foo:
icall icall
; CHECK: icall ; encoding: [0x09,0x95] ; CHECK: icall ; encoding: [0x09,0x95]
; CHECK-INST: icall

llvm/test/MC/AVR/inst-ijmp.s

; RUN: llvm-mc -triple avr -mattr=ijmpcall -show-encoding < %s | FileCheck %s ; RUN: llvm-mc -triple avr -mattr=ijmpcall -show-encoding < %s | FileCheck %s
; RUN: llvm-mc -filetype=obj -triple avr -mattr=ijmpcall < %s | llvm-objdump -d -mattr=ijmpcall - | FileCheck -check-prefix=CHECK-INST %s
foo: foo:
ijmp ijmp
; CHECK: ijmp ; encoding: [0x09,0x94] ; CHECK: ijmp ; encoding: [0x09,0x94]
; CHECK-INST: ijmp

llvm/test/MC/AVR/inst-nop.s

; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s ; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s
; RUN: llvm-mc -filetype=obj -triple avr < %s | llvm-objdump -d - | FileCheck -check-prefix=CHECK-INST %s
foo: foo:
nop nop
; CHECK: nop ; encoding: [0x00,0x00] ; CHECK: nop ; encoding: [0x00,0x00]
; CHECK-INST: nop

llvm/test/MC/AVR/inst-ret.s

; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s ; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s
; RUN: llvm-mc -filetype=obj -triple avr < %s | llvm-objdump -d - | FileCheck -check-prefix=CHECK-INST %s
foo: foo:
ret ret
; CHECK: ret ; encoding: [0x08,0x95] ; CHECK: ret ; encoding: [0x08,0x95]
; CHECK-INST: ret

llvm/test/MC/AVR/inst-reti.s

; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s ; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s
; RUN: llvm-mc -filetype=obj -triple avr < %s | llvm-objdump -d - | FileCheck -check-prefix=CHECK-INST %s
foo: foo:
reti reti
; CHECK: reti ; encoding: [0x18,0x95] ; CHECK: reti ; encoding: [0x18,0x95]
; CHECK-INST: reti

llvm/test/MC/AVR/inst-sleep.s

; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s ; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s
; RUN: llvm-mc -filetype=obj -triple avr < %s | llvm-objdump -d - | FileCheck -check-prefix=CHECK-INST %s
foo: foo:
sleep sleep
; CHECK: sleep ; encoding: [0x88,0x95] ; CHECK: sleep ; encoding: [0x88,0x95]
; CHECK-INST: sleep

llvm/test/MC/AVR/inst-wdr.s

; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s ; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s
; RUN: llvm-mc -filetype=obj -triple avr < %s | llvm-objdump -d - | FileCheck -check-prefix=CHECK-INST %s
foo: foo:
wdr wdr
; CHECK: wdr ; encoding: [0xa8,0x95] ; CHECK: wdr ; encoding: [0xa8,0x95]
; CHECK-INST: wdr