This is an archive of the discontinued LLVM Phabricator instance.

[Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes
ClosedPublic

Authored by mcgrathr on Jan 30 2020, 12:01 PM.

Details

Summary

This is never appropriate on Fuchsia and any future needs for
system library dependencies of compiler-supplied runtimes will
be addressed via .deplibs instead of driver hacks.

Diff Detail

Event Timeline

mcgrathr created this revision.Jan 30 2020, 12:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 30 2020, 12:01 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
phosek accepted this revision.Jan 30 2020, 12:08 PM

LGTM % nit

clang/lib/Driver/ToolChains/CommonArgs.cpp
586

Nit: LLVM style says no braces for blocks with a single statement.

This revision is now accepted and ready to land.Jan 30 2020, 12:08 PM
mcgrathr updated this revision to Diff 241560.Jan 30 2020, 1:06 PM

builds now.

mcgrathr updated this revision to Diff 241561.Jan 30 2020, 1:10 PM

style nit

This revision was automatically updated to reflect the committed changes.