Page MenuHomePhabricator

[lldb/Commands] Fix, rename and document column number argument to breakpoint set.
ClosedPublic

Authored by JDevlieghere on Jan 23 2020, 11:04 AM.

Details

Summary

We were incorrectly parsing the -C argument to breakpoint set as the column breakpoint, even though according to the help this should be the breakpoint command. This fixes that by renaming the option to -u, adding it to help, and adding a test case.

Diff Detail

Event Timeline

JDevlieghere created this revision.Jan 23 2020, 11:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2020, 11:04 AM
jingham accepted this revision.Jan 23 2020, 11:24 AM

LGTM. This is my bad. I put in the parsing for -C in CommandObjectBreakpointSet in an (apparently futile) attempt to remind myself to reserve -C for column number...

This revision is now accepted and ready to land.Jan 23 2020, 11:24 AM
This revision was automatically updated to reflect the committed changes.