Page MenuHomePhabricator

[test] Avoid loop-unroll.c test getting confused by fadd in git revision
ClosedPublic

Authored by russell.gallop on Jan 22 2020, 1:26 AM.

Details

Summary

Saw this test failing as it was matching fadd in a (local) git revision:

F:\git\llvm-project\clang\test\CodeGen\loop-unroll.c:38:30: error: CHECK-DISABLE-UNROLL-NOT: excluded string found in input
// CHECK-DISABLE-UNROLL-NOT: fadd
                             ^
<stdin>:69:92: note: found here
!1 = !{!"clang version 11.0.0 (https://github.com/llvm/llvm-project.git a3eebdb6c1376e528a6fadd5eb33bb6eb986a126)"}

Diff Detail

Event Timeline

russell.gallop created this revision.Jan 22 2020, 1:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2020, 1:26 AM
Herald added a subscriber: zzheng. · View Herald Transcript
asbirlea accepted this revision.Jan 22 2020, 10:20 AM

Oh, wow! Might I ask you add the same for fmul? We may get a revision like that next time :).
Thank you!

This revision is now accepted and ready to land.Jan 22 2020, 10:20 AM
fhahn added a subscriber: fhahn.Jan 22 2020, 10:26 AM

I think we could also just add a single match for something after the generated functions, to limit the scope of CHECK-NOT, e.g add something like CHECK : !0 =

Update to check for start of metadata.

Oh, wow! Might I ask you add the same for fmul? We may get a revision like that next time :).
Thank you!

fmul shouldn't have the same problem as git hashes are only hex characters.

I think we could also just add a single match for something after the generated functions, to limit the scope of CHECK-NOT, e.g add something like CHECK : !0 =

Thanks, that's cleaner.

Note that the diff here is a little confused. There are now no changes to the previous check lines.

This revision was automatically updated to reflect the committed changes.