Page MenuHomePhabricator

[PGO][PGSO] Update BFI in CodeGenPrepare::optimizeSelectInst.
ClosedPublic

Authored by yamauchi on Jan 21 2020, 3:53 PM.

Details

Summary

Without the BFI update, some hot blocks are incorrectly treated as cold code.

This fixes a FDO perf regression in the TSVC benchmark from D71288.

Diff Detail

Event Timeline

yamauchi created this revision.Jan 21 2020, 3:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 21 2020, 3:53 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
davidxl accepted this revision.Jan 21 2020, 4:02 PM

lgtm

llvm/lib/CodeGen/CodeGenPrepare.cpp
6141

I wonder how many more such bugs are there

This revision is now accepted and ready to land.Jan 21 2020, 4:02 PM
yamauchi marked an inline comment as done.Jan 22 2020, 8:38 AM
yamauchi added inline comments.
llvm/lib/CodeGen/CodeGenPrepare.cpp
6141

So do I. Will check.

This revision was automatically updated to reflect the committed changes.
hans added a subscriber: hans.Jan 22 2020, 3:49 PM

Cherry-picked to 10.x in b5cdee9bdce49b31c74b0cf4f8231f66bbc2708e
Please let me know if there are any follow-ups.