Page MenuHomePhabricator

hwasan: Move .note.hwasan.globals note to hwasan.module_ctor comdat.
ClosedPublic

Authored by pcc on Jan 17 2020, 10:06 AM.

Details

Summary

As of D70146 lld GCs comdats as a group and no longer considers notes in
comdats to be GC roots, so we need to move the note to a comdat with a GC root
section (.init_array) in order to prevent lld from discarding the note.

Diff Detail

Event Timeline

pcc created this revision.Jan 17 2020, 10:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2020, 10:06 AM
Herald added a subscriber: hiraditya. · View Herald Transcript

Unit tests: fail. 61974 tests passed, 1 failed and 783 were skipped.

failed: LLVM.Bindings/Go/go.test

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

eugenis accepted this revision.Jan 17 2020, 1:30 PM

LGTM

This revision is now accepted and ready to land.Jan 17 2020, 1:30 PM
This revision was automatically updated to reflect the committed changes.