Page MenuHomePhabricator

Remove unused option that gcc ignored
ClosedPublic

Authored by Jim on Jan 16 2020, 12:48 AM.

Diff Detail

Event Timeline

Jim created this revision.Jan 16 2020, 12:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2020, 12:48 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Jim edited the summary of this revision. (Show Details)Jan 16 2020, 12:49 AM
MaskRay added a comment.EditedJan 16 2020, 10:09 AM

Can we just delete the options?

The misspelled options were added in rC214906 to work around https://clang.debian.net/status.php?version=3.4.2&key=UNKNOWN_ARG . Actually the -ftree* options were not used. Apparently our option names has been wrong for 5 years and nobody complains.

Jim added a comment.Jan 16 2020, 5:46 PM

It should be kept for compatibility. These three options may be used in other projects compiled by gcc.
Clang should ignore it.
https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html

These three options may be used in other projects compiled by gcc.

We can add them on demand. I don't see a rationale to add them preemptively.

Jim updated this revision to Diff 239246.Jan 21 2020, 1:02 AM
Jim retitled this revision from [NFC] Fix options name typo to Remove unused option that gcc ignored.
Jim edited the summary of this revision. (Show Details)

Address the comment. Delete the options.

This revision is now accepted and ready to land.Tue, Feb 18, 2:55 PM
MaskRay accepted this revision.Tue, Feb 18, 3:05 PM
This revision was automatically updated to reflect the committed changes.