This is an archive of the discontinued LLVM Phabricator instance.

[lldb][NFC] Rewrite python_api/rdar-12481949 test
ClosedPublic

Authored by teemperor on Jan 13 2020, 2:55 AM.

Details

Summary

This renames the test rdar-12481949 to get-value-32bit-int as it just tests that we return the
correct result get calling GetValueAsSigned/GetValueAsUnsigned on 32-bit integers.

It also deletes all the strange things going on in this test including resetting the data formatters (which are to my
knowledge not used to calculate scalar values) and testing Python's long integers (let's just assume that our Python
distribution works correctly). Also modernises the setup code.

Diff Detail

Event Timeline

teemperor created this revision.Jan 13 2020, 2:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2020, 2:55 AM
aprantl accepted this revision.Jan 13 2020, 9:34 AM

Awesome.

This revision is now accepted and ready to land.Jan 13 2020, 9:34 AM
This revision was automatically updated to reflect the committed changes.
lldb/packages/Python/lldbsuite/test/python_api/rdar-12481949/Test-rdar-12481949.py