Page MenuHomePhabricator

[mlir] fix test failure in EDSC/builder-api-test
ClosedPublic

Authored by inouehrs on Jan 8 2020, 10:06 PM.

Details

Summary

This patch fixes a test failure on a non-intel (PowerPC64) box.
The two affine.load are independent and hence llvm may reorder them.
The CHECK lines are modified for supporting reordered case.

Diff Detail

Event Timeline

inouehrs created this revision.Jan 8 2020, 10:06 PM
ftynse requested changes to this revision.Jan 9 2020, 1:17 AM
ftynse added inline comments.
mlir/test/EDSC/builder-api-test.cpp
727–730

Please capture the names of SSA values in their definition place instead of using them directly. E.g.,

CHECK-LABEL: func @indirect_access
CHECK-SAME: (%[[A:.*]], %[[B:.*]], ...
CHECK-DAG: [[loadedB:%.*]] = affine.load %[[B]]
This revision now requires changes to proceed.Jan 9 2020, 1:17 AM
inouehrs updated this revision to Diff 236999.Jan 9 2020, 2:49 AM
  • capture the name of symbols instead of using hard-coded names
inouehrs marked an inline comment as done.Jan 9 2020, 2:51 AM
ftynse accepted this revision.Jan 9 2020, 4:58 AM
This revision is now accepted and ready to land.Jan 9 2020, 4:58 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2020, 5:12 AM