This is an archive of the discontinued LLVM Phabricator instance.

Differential D72408

[MLIR] Don't use SSA names directly for std.view canonicalization test
ClosedPublic

Authored by asaadaldien on Jan 8 2020, 12:30 PM.

Details

Reviewers
rriddle
nicolasvasilache
Commits
rGf84d3200528a: [MLIR] Don't use SSA names directly for std.view canonicalization test

Diff Detail

Event Timeline

asaadaldien created this revision.Jan 8 2020, 12:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2020, 12:30 PM
Herald added subscribers: llvm-commits, lucyrfox, mgester and 6 others. · View Herald Transcript
merge_guards_bot added a subscriber: merge_guards_bot.Jan 8 2020, 12:53 PM

Unit tests: pass. 61323 tests passed, 0 failed and 736 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Harbormaster failed remote builds in B43522: Diff 236887!Jan 8 2020, 1:00 PM
nicolasvasilache accepted this revision.Jan 8 2020, 2:09 PM
This revision is now accepted and ready to land.Jan 8 2020, 2:09 PM
Closed by commit rGf84d3200528a: [MLIR] Don't use SSA names directly for std.view canonicalization test (authored by asaadaldien). · Explain WhyJan 8 2020, 2:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
test/
Transforms/
10 lines

Diff 236913

mlir/test/Transforms/canonicalize.mlir

Show First 20 Lines • Show All 697 Lines • ▼ Show 20 Linesfunc @view(%arg0 : index) {
// CHECK: %[[ALLOC_MEM:.*]] = alloc() : memref<2048xi8> // CHECK: %[[ALLOC_MEM:.*]] = alloc() : memref<2048xi8>
%0 = alloc() : memref<2048xi8> %0 = alloc() : memref<2048xi8>
%c0 = constant 0 : index %c0 = constant 0 : index
%c7 = constant 7 : index %c7 = constant 7 : index
%c11 = constant 11 : index %c11 = constant 11 : index
%c15 = constant 15 : index %c15 = constant 15 : index
// Test: fold constant sizes and offset, update map with static stride/offset. // Test: fold constant sizes and offset, update map with static stride/offset.
// CHECK: std.view %0[][] : memref<2048xi8> to memref<7x11xf32, #[[VIEW_MAP0]]> // CHECK: std.view %[[ALLOC_MEM]][][] : memref<2048xi8> to memref<7x11xf32, #[[VIEW_MAP0]]>
%1 = view %0[%c15][%c7, %c11] %1 = view %0[%c15][%c7, %c11]
: memref<2048xi8> to memref<?x?xf32, #TEST_VIEW_MAP0> : memref<2048xi8> to memref<?x?xf32, #TEST_VIEW_MAP0>
load %1[%c0, %c0] : memref<?x?xf32, #TEST_VIEW_MAP0> load %1[%c0, %c0] : memref<?x?xf32, #TEST_VIEW_MAP0>
// Test: fold constant sizes but not offset, update map with static stride. // Test: fold constant sizes but not offset, update map with static stride.
// Test that we do not a fold dynamic dim which is not produced by a constant. // Test that we do not a fold dynamic dim which is not produced by a constant.
// CHECK: std.view %0[%arg0][] : memref<2048xi8> to memref<7x11xf32, #[[VIEW_MAP1]]> // CHECK: std.view %[[ALLOC_MEM]][%arg0][] : memref<2048xi8> to memref<7x11xf32, #[[VIEW_MAP1]]>
%2 = view %0[%arg0][%c7, %c11] %2 = view %0[%arg0][%c7, %c11]
: memref<2048xi8> to memref<?x?xf32, #TEST_VIEW_MAP0> : memref<2048xi8> to memref<?x?xf32, #TEST_VIEW_MAP0>
load %2[%c0, %c0] : memref<?x?xf32, #TEST_VIEW_MAP0> load %2[%c0, %c0] : memref<?x?xf32, #TEST_VIEW_MAP0>
// Test: fold constant offset but not sizes, update map with constant offset. // Test: fold constant offset but not sizes, update map with constant offset.
// Test that we fold constant offset but not dynamic dims. // Test that we fold constant offset but not dynamic dims.
// CHECK: std.view %0[][%arg0, %arg0] : memref<2048xi8> to memref<?x?xf32, #[[VIEW_MAP2]]> // CHECK: std.view %[[ALLOC_MEM]][][%arg0, %arg0] : memref<2048xi8> to memref<?x?xf32, #[[VIEW_MAP2]]>
%3 = view %0[%c15][%arg0, %arg0] %3 = view %0[%c15][%arg0, %arg0]
: memref<2048xi8> to memref<?x?xf32, #TEST_VIEW_MAP0> : memref<2048xi8> to memref<?x?xf32, #TEST_VIEW_MAP0>
load %3[%c0, %c0] : memref<?x?xf32, #TEST_VIEW_MAP0> load %3[%c0, %c0] : memref<?x?xf32, #TEST_VIEW_MAP0>
// Test: fold one constant dim, no offset, should update with constant // Test: fold one constant dim, no offset, should update with constant
// stride on dim 1, but leave dynamic stride on dim 0. // stride on dim 1, but leave dynamic stride on dim 0.
// CHECK: std.view %0[][%arg0, %arg0] : memref<2048xi8> to memref<?x?x7xf32, #[[VIEW_MAP3]]> // CHECK: std.view %[[ALLOC_MEM]][][%arg0, %arg0] : memref<2048xi8> to memref<?x?x7xf32, #[[VIEW_MAP3]]>
%4 = view %0[][%arg0, %arg0, %c7] %4 = view %0[][%arg0, %arg0, %c7]
: memref<2048xi8> to memref<?x?x?xf32, #TEST_VIEW_MAP1> : memref<2048xi8> to memref<?x?x?xf32, #TEST_VIEW_MAP1>
load %4[%c0, %c0, %c0] : memref<?x?x?xf32, #TEST_VIEW_MAP1> load %4[%c0, %c0, %c0] : memref<?x?x?xf32, #TEST_VIEW_MAP1>
// Test: preserve an existing static dim size while folding a dynamic // Test: preserve an existing static dim size while folding a dynamic
// dimension and offset. // dimension and offset.
// CHECK: std.view %[[ALLOC_MEM]][][] : memref<2048xi8> to memref<7x4xf32, #[[VIEW_MAP4]]> // CHECK: std.view %[[ALLOC_MEM]][][] : memref<2048xi8> to memref<7x4xf32, #[[VIEW_MAP4]]>
%5 = view %0[%c15][%c7] : memref<2048xi8> to memref<?x4xf32, #TEST_VIEW_MAP2> %5 = view %0[%c15][%c7] : memref<2048xi8> to memref<?x4xf32, #TEST_VIEW_MAP2>
load %5[%c0, %c0] : memref<?x4xf32, #TEST_VIEW_MAP2> load %5[%c0, %c0] : memref<?x4xf32, #TEST_VIEW_MAP2>
// Test: folding static alloc and memref_cast into a view. // Test: folding static alloc and memref_cast into a view.
// CHECK: std.view %0[][%c15, %c7] : memref<2048xi8> to memref<?x?xf32> // CHECK: std.view %[[ALLOC_MEM]][][%c15, %c7] : memref<2048xi8> to memref<?x?xf32>
%6 = memref_cast %0 : memref<2048xi8> to memref<?xi8> %6 = memref_cast %0 : memref<2048xi8> to memref<?xi8>
%7 = view %6[%c15][%c7] : memref<?xi8> to memref<?x?xf32> %7 = view %6[%c15][%c7] : memref<?xi8> to memref<?x?xf32>
load %7[%c0, %c0] : memref<?x?xf32> load %7[%c0, %c0] : memref<?x?xf32>
return return
} }
// ----- // -----
▲ Show 20 Lines • Show All 132 Lines • Show Last 20 Lines