Page MenuHomePhabricator

[MLIR] Fix ML IR build on Windows with Visual Studio
ClosedPublic

Authored by stella.stamenova on Jan 8 2020, 10:07 AM.

Details

Summary

Right now the path for each lib in whole_archive_link when MSVC is used as the compiler is not a full path - and it's not even the correct path when VS is used to build. This patch sets the lib path to a full path using CMAKE_CFG_INTDIR which means the path will be correct regardless of whether ninja, make or VS is used and it will always be a full path.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2020, 10:07 AM
jpienaar accepted this revision.Jan 8 2020, 10:22 AM

Thanks!

This revision is now accepted and ready to land.Jan 8 2020, 10:22 AM
This revision was automatically updated to reflect the committed changes.