This is an archive of the discontinued LLVM Phabricator instance.

Remove NaCl*TargetCodeGenInfo
ClosedPublic

Authored by dschuff on Jan 28 2015, 1:10 PM.

Details

Summary

They just existed before to use NaCl's custom ABIInfos; now that those are gone,
the custom TargetCodeGenInfo is no longer needed either.

Diff Detail

Event Timeline

dschuff updated this revision to Diff 18915.Jan 28 2015, 1:10 PM
dschuff retitled this revision from to Remove NaClX86_64TargetCodeGenInfo.
dschuff updated this object.
dschuff edited the test plan for this revision. (Show Details)
dschuff added a reviewer: jvoung.
dschuff added a subscriber: Unknown Object (MLST).
jvoung added inline comments.Jan 28 2015, 2:57 PM
lib/CodeGen/TargetInfo.cpp
5061

Can the ARM one be removed too?

dschuff updated this revision to Diff 18925.Jan 28 2015, 3:40 PM
  • Also remove NaClARMTargetCodeGenInfo
lib/CodeGen/TargetInfo.cpp
5061

Done

jvoung accepted this revision.Jan 28 2015, 4:26 PM
jvoung edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 28 2015, 4:26 PM
dschuff retitled this revision from Remove NaClX86_64TargetCodeGenInfo to Remove NaCl*TargetCodeGenInfo.Jan 28 2015, 4:46 PM
dschuff updated this object.
dschuff edited edge metadata.
This revision was automatically updated to reflect the committed changes.