Page MenuHomePhabricator

jvoung (Jan Voung)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2013, 11:12 AM (332 w, 3 d)

Recent Activity

Jul 16 2015

jvoung accepted D11271: Change Native Client x86 usr include and link path to match SDK expectations.

LGTM

Jul 16 2015, 11:14 AM

Jul 10 2015

jvoung committed rL241933: Fix enum BitcodeError to not define a zero-valued error code..
Fix enum BitcodeError to not define a zero-valued error code.
Jul 10 2015, 12:46 PM
jvoung closed D10815: Fix enum BitcodeError to not define 0. by committing rL241933: Fix enum BitcodeError to not define a zero-valued error code..
Jul 10 2015, 12:46 PM
jvoung added a comment to D10815: Fix enum BitcodeError to not define 0..

I think it dropped off Karl's radar. He's on vacation right now, but I could help clang-format/commit it for him today.

Jul 10 2015, 12:20 PM

Jul 9 2015

jvoung added a comment to D11072: Implement tool to convert bitcode to text..

Made a quick scan over (not a full review).

Jul 9 2015, 1:48 PM

Jun 24 2015

jvoung accepted D10701: Relax assertion in x86_64 byval argument handling for 32-bit pointers.

LGTM

Jun 24 2015, 3:03 PM
jvoung added inline comments to D10701: Relax assertion in x86_64 byval argument handling for 32-bit pointers.
Jun 24 2015, 2:04 PM
jvoung accepted D10697: Use GetLinkerPath utility function to find linker for NaCl toolchain.

Worth adding a test case to test/Driver/fuse-ld.c ?

Jun 24 2015, 10:54 AM

Apr 21 2015

jvoung added a comment to D8907: Add bitcode test to verify functions can be materialized out of order..

Hmm don't think I got the email for this, but saw it on my list.

Apr 21 2015, 12:56 PM

Apr 20 2015

jvoung added a comment to D9131: [MC] When using bundle aligment, align sections to bundle size.

How about use "llvm-readobj -sections" to test? That will print out the sections plus the "AddressAlignment".

Apr 20 2015, 4:13 PM

Apr 15 2015

jvoung added a comment to D8931: Add test showing error in StreamingMemoryObject.setKnownObjectSize()..

Thanks -- looks okay to me, but wait for Rafael to take a look too since he some earlier questions?

Apr 15 2015, 10:42 AM

Apr 14 2015

jvoung added a comment to D8931: Add test showing error in StreamingMemoryObject.setKnownObjectSize()..

Mostly thinking out loud, but a few suggestions in the sea of text too.

Apr 14 2015, 10:29 AM

Apr 10 2015

jvoung accepted D8902: NaCl ARM: fix assembler float abi flags.

Otherwise LGTM

Apr 10 2015, 9:34 AM

Apr 9 2015

jvoung added inline comments to D8786: Refactor bitcode reader to simplify control..
Apr 9 2015, 2:33 PM

Apr 1 2015

jvoung added a comment to D8786: Refactor bitcode reader to simplify control..

A couple nits for now, but still trying to read through and understand what's happening in the streaming and lazy cases...

Apr 1 2015, 4:49 PM

Mar 27 2015

jvoung accepted D8590: Add driver support for Native Client SDK.

otherwise LGTM

Mar 27 2015, 1:23 PM

Mar 25 2015

jvoung added inline comments to D8590: Add driver support for Native Client SDK.
Mar 25 2015, 2:41 PM

Mar 10 2015

jvoung added a comment to D8240: Make NaCl's use of .init_array for static constructors match Linux.

looks okay -- a couple nits

Mar 10 2015, 6:04 PM

Mar 3 2015

jvoung committed rL231172: Move TargetLibraryInfo data from two files into one common .def file..
Move TargetLibraryInfo data from two files into one common .def file.
Mar 3 2015, 3:44 PM
jvoung closed D7845: Move TargetLibraryInfo data from two files into one common .def file. by committing rL231172: Move TargetLibraryInfo data from two files into one common .def file..
Mar 3 2015, 3:44 PM

Mar 2 2015

jvoung added a comment to D7845: Move TargetLibraryInfo data from two files into one common .def file..

Okay, strict sounds good to me. It should be pretty easy to switch to something more flexible later if needed.

Mar 2 2015, 4:00 PM
jvoung updated the diff for D7845: Move TargetLibraryInfo data from two files into one common .def file..

Make the .def handle the definition details, and the .h/.cpp just do "#define TLI_DEFINE_ENUM ... #include ..."

Mar 2 2015, 3:58 PM

Feb 26 2015

jvoung added a comment to D7845: Move TargetLibraryInfo data from two files into one common .def file..

Hmm, I don't have strong feelings either way, except that I think the enum and the string in the .def file should be clustered together so that it remains clear both are simultaneously defined whenever adding a TLI function.

Feb 26 2015, 2:16 PM

Feb 24 2015

jvoung updated the diff for D7845: Move TargetLibraryInfo data from two files into one common .def file..

Split into TLI_HANDLE_ENUM, TLI_HANDLE_STRING macros so user can opt in separately.

Feb 24 2015, 5:40 PM
jvoung accepted D7734: InstCombine: extract instead of shuffle when performing vector/array type punning.

lgtm

Feb 24 2015, 1:25 PM

Feb 23 2015

jvoung retitled D7845: Move TargetLibraryInfo data from two files into one common .def file. from to Move TargetLibraryInfo data from two files into one common .def file..
Feb 23 2015, 5:25 PM
jvoung added a comment to D7734: InstCombine: extract instead of shuffle when performing vector/array type punning.

Mostly nits, but looks okay to me.

Feb 23 2015, 11:53 AM

Feb 11 2015

jvoung committed rL228842: Gold-plugin: Broaden scope of get/release_input_file to scope of Module..
Gold-plugin: Broaden scope of get/release_input_file to scope of Module.
Feb 11 2015, 8:14 AM
jvoung closed D7539: Gold-plugin: Broaden scope of get/release_input_file to scope of Module. by committing rL228842: Gold-plugin: Broaden scope of get/release_input_file to scope of Module..
Feb 11 2015, 8:14 AM

Feb 10 2015

jvoung updated the diff for D7539: Gold-plugin: Broaden scope of get/release_input_file to scope of Module..

Add test using --no-map-whole-files. Also, only pass the filesize.

Feb 10 2015, 4:42 PM
jvoung added a comment to D7539: Gold-plugin: Broaden scope of get/release_input_file to scope of Module..

I've been testing with gold instead bfd ld.

Feb 10 2015, 1:00 PM
jvoung retitled D7539: Gold-plugin: Broaden scope of get/release_input_file to scope of Module. from to Gold-plugin: Broaden scope of get/release_input_file to scope of Module..
Feb 10 2015, 11:54 AM

Feb 4 2015

jvoung accepted D7416: libc++: remove unused variable in random_device::operator()().

LGTM thanks

Feb 4 2015, 12:25 PM

Feb 2 2015

jvoung committed rL227809: Fix ARM peephole optimizeCompare to avoid optimizing unsigned cmp to 0..
Fix ARM peephole optimizeCompare to avoid optimizing unsigned cmp to 0.
Feb 2 2015, 8:58 AM
jvoung closed D7274: Fix ARM peephole optimizeCompare to avoid optimizing unsigned cmp to 0. by committing rL227809: Fix ARM peephole optimizeCompare to avoid optimizing unsigned cmp to 0..
Feb 2 2015, 8:58 AM

Jan 31 2015

jvoung updated the diff for D7274: Fix ARM peephole optimizeCompare to avoid optimizing unsigned cmp to 0..

Apply JF's review suggestion -- annotate the switch cases w/ the bits used.

Jan 31 2015, 7:22 PM

Jan 29 2015

jvoung retitled D7274: Fix ARM peephole optimizeCompare to avoid optimizing unsigned cmp to 0. from to Fix ARM peephole optimizeCompare to avoid optimizing unsigned cmp to 0..
Jan 29 2015, 3:17 PM

Jan 28 2015

jvoung accepted D7234: Remove NaCl*TargetCodeGenInfo.

LGTM

Jan 28 2015, 4:26 PM
jvoung added inline comments to D7234: Remove NaCl*TargetCodeGenInfo.
Jan 28 2015, 2:57 PM
jvoung accepted D7206: Remove support for pnaclcall attribute.
Jan 28 2015, 11:32 AM
jvoung added a comment to D7206: Remove support for pnaclcall attribute.

Otherwise LGTM too.

Jan 28 2015, 8:54 AM

Dec 15 2014

jvoung added inline comments to D6629: x86: Emit LAHF/SAHF instead of PUSHF/POPF.
Dec 15 2014, 5:24 PM

Dec 12 2014

jvoung accepted D6630: x86: Emit LOCK prefix after DATA16.

LGTM

Dec 12 2014, 2:40 PM

Dec 5 2014

jvoung closed D6514: Use 32-bit ebp for NaCl64 in a limited case: llvm.frameaddress..

Closed by commit rL223510 (authored by @jvoung).

Dec 5 2014, 12:56 PM

Dec 3 2014

jvoung retitled D6514: Use 32-bit ebp for NaCl64 in a limited case: llvm.frameaddress. from to Use 32-bit ebp for NaCl64 in a limited case: llvm.frameaddress..
Dec 3 2014, 3:35 PM

Nov 11 2014

jvoung added a comment to D6208: Move arm-nacl DL description string setting from ctor to setABI..

Okay I'll wait and see what happens to -target-abi. Thanks!

Nov 11 2014, 10:24 AM

Nov 10 2014

jvoung retitled D6208: Move arm-nacl DL description string setting from ctor to setABI. from to Move arm-nacl DL description string setting from ctor to setABI..
Nov 10 2014, 5:39 PM

Nov 5 2014

jvoung added inline comments to D6136: [x86 fast-isel] Materialize allocas with the correct-sized lea for ILP32.
Nov 5 2014, 11:16 AM

Oct 29 2014

jvoung closed D5987: Fix getRelocationValueString to return the symbol name for EM_386..

Closed by commit rL220866 (authored by @jvoung).

Oct 29 2014, 11:47 AM
jvoung updated D5987: Fix getRelocationValueString to return the symbol name for EM_386..
Oct 29 2014, 11:14 AM

Oct 24 2014

jvoung retitled D5987: Fix getRelocationValueString to return the symbol name for EM_386. from to Fix getRelocationValueString to return the symbol name for EM_386..
Oct 24 2014, 6:18 PM

Oct 22 2014

jvoung accepted D5915: [MC] Attach labels to existing fragments instead of using a separate fragment.

LGTM too

Oct 22 2014, 2:38 PM
jvoung added inline comments to D5915: [MC] Attach labels to existing fragments instead of using a separate fragment.
Oct 22 2014, 11:57 AM

Oct 15 2014

jvoung added a comment to D5801: [MC] Make bundle alignment mode setting idempotent and support nested bundles.

otherwise LGTM too

Oct 15 2014, 10:03 AM

Oct 2 2014

jvoung closed D5555: [x32/NaCl] Check if method pointers straddle an eightbyte to classify Hi.

Closed by commit rL218889 (authored by @jvoung).

Oct 2 2014, 10:07 AM

Sep 30 2014

jvoung updated the diff for D5555: [x32/NaCl] Check if method pointers straddle an eightbyte to classify Hi.

Give test struct a better name.

Sep 30 2014, 6:46 PM
jvoung updated subscribers of D5555: [x32/NaCl] Check if method pointers straddle an eightbyte to classify Hi.
Sep 30 2014, 6:10 PM
jvoung updated the diff for D5555: [x32/NaCl] Check if method pointers straddle an eightbyte to classify Hi.

Lo instead of Current.

Sep 30 2014, 6:03 PM
jvoung retitled D5555: [x32/NaCl] Check if method pointers straddle an eightbyte to classify Hi from to [x32/NaCl] Check if method pointers straddle an eightbyte to classify Hi.
Sep 30 2014, 6:02 PM

Jul 11 2014

jvoung added inline comments to D4449: Add a dereferencable attribute.
Jul 11 2014, 11:21 AM