This is an archive of the discontinued LLVM Phabricator instance.

Add gdb pretty printer for MutableArrayRef, remove ConstArrayRef.
ClosedPublic

Authored by csigg on Jan 3 2020, 3:12 AM.

Diff Detail

Event Timeline

csigg created this revision.Jan 3 2020, 3:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2020, 3:12 AM

Unit tests: pass. 61127 tests passed, 0 failed and 728 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

dblaikie accepted this revision.Jan 3 2020, 9:44 PM

Ah, thanks for that - seems I wrote this as I had /wanted/ ArrayRef to be implemented, rather than how it ended up being implemented. (when MutableArrayRef was proposed, I had proposed changing ArrayRef to be mutable and introducing ConstArrayRef but folks didn't want the churn - guess that stuck in my head a bit).

This revision is now accepted and ready to land.Jan 3 2020, 9:44 PM
This revision was automatically updated to reflect the committed changes.