This is an archive of the discontinued LLVM Phabricator instance.

Differential D72124

[mlir] Compilation fix: use LLVM_ATTRIBUTE_UNUSED following 6656e961c08393c3949412ef945ade0272b66fca
ClosedPublic

Authored by aganea on Jan 2 2020, 6:36 PM.

Details

Reviewers
echristo
antiagainst
Commits
rGe19188af0a26: [mlir] Compilation fix: use LLVM_ATTRIBUTE_UNUSED following…

Diff Detail

Event Timeline

aganea created this revision.Jan 2 2020, 6:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 2 2020, 6:36 PM
Herald added subscribers: llvm-commits, lucyrfox, mgester and 8 others. · View Herald Transcript
antiagainst accepted this revision.Jan 3 2020, 4:52 AM

Thanks for the fix!

This revision is now accepted and ready to land.Jan 3 2020, 4:52 AM
Closed by commit rGe19188af0a26: [mlir] Compilation fix: use LLVM_ATTRIBUTE_UNUSED following… (authored by aganea). · Explain WhyJan 3 2020, 1:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
tools/
mlir-tblgen/
8 lines

Diff 236122

mlir/tools/mlir-tblgen/RewriterGen.cpp

Show First 20 Lines • Show All 1,022 Lines • ▼ Show 20 Lines LLVM_DEBUG(llvm::dbgs()
<< "=== start generating pattern '" << name << "' ===\n"); << "=== start generating pattern '" << name << "' ===\n");
PatternEmitter(p, &recordOpMap, os).emit(name); PatternEmitter(p, &recordOpMap, os).emit(name);
LLVM_DEBUG(llvm::dbgs() LLVM_DEBUG(llvm::dbgs()
<< "=== done generating pattern '" << name << "' ===\n"); << "=== done generating pattern '" << name << "' ===\n");
rewriterNames.push_back(std::move(name)); rewriterNames.push_back(std::move(name));
} }
// Emit function to add the generated matchers to the pattern list. // Emit function to add the generated matchers to the pattern list.
os << "void\n"; os << "void LLVM_ATTRIBUTE_UNUSED populateWithGenerated(MLIRContext "
os << "#if !defined(_MSC_VER) || defined(__clang__)\n"; "*context, OwningRewritePatternList *patterns) {\n";
os << "__attribute__((unused))\n";
os << "#endif\n";
os << "populateWithGenerated(MLIRContext *context, "
<< "OwningRewritePatternList *patterns) {\n";
for (const auto &name : rewriterNames) { for (const auto &name : rewriterNames) {
os << " patterns->insert<" << name << ">(context);\n"; os << " patterns->insert<" << name << ">(context);\n";
} }
os << "}\n"; os << "}\n";
} }
static mlir::GenRegistration static mlir::GenRegistration
genRewriters("gen-rewriters", "Generate pattern rewriters", genRewriters("gen-rewriters", "Generate pattern rewriters",
[](const RecordKeeper &records, raw_ostream &os) { [](const RecordKeeper &records, raw_ostream &os) {
emitRewriters(records, os); emitRewriters(records, os);
return false; return false;
}); });