This assumed a single pattern if there was a predicate. Relax this a
bit, and allow multiple patterns as long as they have the same class.
This was only broken for the DAG path. GlobalISel seems to have
handled this correctly already.
Paths
| Differential D72009
TableGen: Fix assert on PatFrags with predicate code ClosedPublic Authored by arsenm on Dec 30 2019, 9:57 AM.
Details
Summary This assumed a single pattern if there was a predicate. Relax this a This was only broken for the DAG path. GlobalISel seems to have
Diff Detail Event TimelineThis revision is now accepted and ready to land.Dec 30 2019, 11:15 AM Comment Actions LGTM too. IIRC, the ability to have multiple trees came after the original implementation so I think we just had a direct conversion.
Revision Contents
Diff 235615 llvm/test/TableGen/predicate-patfags.td
llvm/utils/TableGen/CodeGenDAGPatterns.cpp
|