Page MenuHomePhabricator

[libcxx] [test] Include missing <limits> header.
AcceptedPublic

Authored by amakc11 on Dec 26 2019, 9:10 AM.

Details

Summary

The C++ standard requires the class template numeric_limits to be located in the <limits> header. Some tests use this class template, but do not include this header directly. As a result, these tests don't compile against some compatible libraries. This patch fixes the problem.

Diff Detail

Event Timeline

amakc11 created this revision.Dec 26 2019, 9:10 AM
Herald added a project: Restricted Project. · View Herald Transcript
mclow.lists accepted this revision.Dec 26 2019, 4:31 PM
mclow.lists added a subscriber: mclow.lists.

LGTM

This revision is now accepted and ready to land.Dec 26 2019, 4:31 PM

I have no commit access to Monorepo. Somebody should commit this revision. Thanks.

amakc11 updated this revision to Diff 237669.Jan 13 2020, 7:12 AM

Detected one more file missing this header. Diff is updated.