This is an archive of the discontinued LLVM Phabricator instance.

[NVPTX] Fixes -Wrange-loop-analysis warnings
ClosedPublic

Authored by Mordante on Dec 22 2019, 8:22 AM.

Reviewers

Commits

rG31262d6722c7: [NVPTX] Fixes -Wrange-loop-analysis warnings

Summary

This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall.

This revision is now accepted and ready to land.Dec 22 2019, 8:31 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Target/

NVPTX/

2 lines

Show First 20 Lines • Show All 606 Lines • ▼ Show 20 Lines	bool NVPTXDAGToDAGISel::tryEXTRACT_VECTOR_ELEMENT(SDNode *N) {

// We only care about f16x2 as it's the only real vector type we		// We only care about f16x2 as it's the only real vector type we
// need to deal with.		// need to deal with.
if (Vector.getSimpleValueType() != MVT::v2f16)		if (Vector.getSimpleValueType() != MVT::v2f16)
return false;		return false;

// Find and record all uses of this vector that extract element 0 or 1.		// Find and record all uses of this vector that extract element 0 or 1.
SmallVector<SDNode *, 4> E0, E1;		SmallVector<SDNode *, 4> E0, E1;
for (const auto &U : Vector.getNode()->uses()) {		for (auto U : Vector.getNode()->uses()) {
if (U->getOpcode() != ISD::EXTRACT_VECTOR_ELT)		if (U->getOpcode() != ISD::EXTRACT_VECTOR_ELT)
continue;		continue;
if (U->getOperand(0) != Vector)		if (U->getOperand(0) != Vector)
continue;		continue;
if (const ConstantSDNode *IdxConst =		if (const ConstantSDNode *IdxConst =
dyn_cast<ConstantSDNode>(U->getOperand(1))) {		dyn_cast<ConstantSDNode>(U->getOperand(1))) {
if (IdxConst->getZExtValue() == 0)		if (IdxConst->getZExtValue() == 0)
E0.push_back(U);		E0.push_back(U);
▲ Show 20 Lines • Show All 3,143 Lines • Show Last 20 Lines