This is an archive of the discontinued LLVM Phabricator instance.

[X86] Mark various pointer arguments in builtins as const
ClosedPublic

Authored by wristow on Dec 19 2019, 10:28 AM.

Details

Summary

Enabling -Wcast-qual identified many casts in various system headers
that were dropping the const qualifier. Fixing those missing
qualifiers pointed out that a few of the definitions of the builtins
did not properly identify their arguments as 'const' pointers. This
commit fixes those builtin definitions, and the system header files
so that they no longer drop the qualifier.

Diff Detail

Event Timeline

wristow created this revision.Dec 19 2019, 10:28 AM
This revision is now accepted and ready to land.Dec 19 2019, 10:43 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2019, 11:53 AM

Thanks for the quick review.