This is an archive of the discontinued LLVM Phabricator instance.

Putting all the standard tool options into a "Generic" category.
ClosedPublic

Authored by beanz on Jan 23 2015, 11:20 AM.

Details

Summary

This puts all the options that CommandLine.cpp implements into a category so that the APIs to hide options can not hide based on the generic category instead of string matching a partial list of argument strings.

This patch is pretty simple and straight forward but it does impact the -help output of all tools using cl::opt. Specifically the options implemented in CommandLine.cpp (help, help-list, help-hidden, help-list-hidden, print-options, print-all-options, version) are all grouped together into an Option category, and these options are never hidden by the cl::HideUnrelatedOptions API.

Diff Detail

Event Timeline

beanz updated this revision to Diff 18684.Jan 23 2015, 11:20 AM
beanz retitled this revision from to Putting all the standard tool options into a "Generic" category..
beanz updated this object.
beanz edited the test plan for this revision. (Show Details)
beanz added reviewers: dexonsmith, chandlerc, majnemer.
beanz added a subscriber: Unknown Object (MLST).
beanz updated this revision to Diff 18700.Jan 23 2015, 4:53 PM

Updated the test case for HideUnrelatedOptions API to validate that "generic" options are not hidden.

This revision was automatically updated to reflect the committed changes.