The patch fixes Int64Type and IntMaxType data type definitions, updates existing tests, and adds two new test cases to check built-in macros in case of N32 ABI.
Details
Details
- Reviewers
dsanders - Commits
- rG6279378e8221: Merging r226877: --------------------------------------------------------------…
rG495523e4ea3a: [Mips] Fix type of 64-bit integer in case of MIPS N64 ABI
rC226877: [Mips] Fix type of 64-bit integer in case of MIPS N64 ABI
rL226877: [Mips] Fix type of 64-bit integer in case of MIPS N64 ABI
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Thanks for fixing this so quickly. LGTM with a small correction. We haven't changed 'long long' itself so we shouldn't change its LL constant suffix on LONG_LONG_MAX to L.
test/Preprocessor/init.c | ||
---|---|---|
3739 | This one should stay as LL since we haven't changed long long itself. | |
3947 | This one should stay LL since we haven't changed long long itself |
Comment Actions
@hans: Would you be happy for me to merge this to the branch after it's been committed and gone through buildbot?
It fixes a warning:
tmp.c:6:19: warning: format specifies type 'intmax_t' (aka 'long long') but the argument has type 'intmax_t' (aka 'long') [-Wformat] printf("%jd\n", a); ~~~ ^ %jd
emitted when compiling:
#include <stdio.h> #include <stdint.h> int main(void) { intmax_t a = 0; printf("%jd\n", a); return 0; }
This one should stay as LL since we haven't changed long long itself.