Page MenuHomePhabricator

Deprecate the hasDefaultArgument matcher
ClosedPublic

Authored by steveire on Dec 7 2019, 10:24 AM.

Details

Summary

It doesn't provide a way to match on the contents of the default
argumment. Rather than give it that capability, make it deprecated and
recomment the use of hasInitializer instead.

Diff Detail

Event Timeline

steveire created this revision.Dec 7 2019, 10:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2019, 10:24 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaron.ballman accepted this revision.Dec 7 2019, 1:23 PM

LGTM with a small doc request.

clang/include/clang/ASTMatchers/ASTMatchers.h
6555

It would probably be useful to show an equivalent expression to hasDefaultArgument() as well, e.g., parmVarDecl(hasInitializer(anything())).

This revision is now accepted and ready to land.Dec 7 2019, 1:23 PM
This revision was automatically updated to reflect the committed changes.