Page MenuHomePhabricator

Adding a new cl::HideUnrelatedOptions API to allow clang to migrate off cl::getRegisteredOptions.
ClosedPublic

Authored by beanz on Jan 21 2015, 10:44 AM.

Details

Summary

cl::getRegisteredOptions really exposes some of the innards of how command line parsing is implemented. Exposing new APIs that allow us to disentangle client code from implementation details will allow us to make more extensive changes to command line parsing.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 18535.Jan 21 2015, 10:44 AM
beanz retitled this revision from to Adding a new cl::HideUnrelatedOptions API to allow clang to migrate off cl::getRegisteredOptions..
beanz updated this object.
beanz edited the test plan for this revision. (Show Details)
beanz added reviewers: chandlerc, dexonsmith.
beanz added a subscriber: Unknown Object (MLST).
dexonsmith edited edge metadata.Jan 21 2015, 11:43 AM

Testcase?

LGTM once you add one, with a style nit below.

beanz updated this revision to Diff 18553.Jan 21 2015, 2:14 PM
beanz edited edge metadata.

Updates based on Duncan's feedback.

  • Using C++ range-based for loop
  • Added a unit test case
beanz accepted this revision.Jan 21 2015, 2:42 PM
beanz added a reviewer: beanz.

Marking revision as accepted based on the LGTM from Duncan.

Thanks, will land shortly.

This revision is now accepted and ready to land.Jan 21 2015, 2:42 PM
This revision was automatically updated to reflect the committed changes.