This is an archive of the discontinued LLVM Phabricator instance.

[Gold] Add missing target flag to X86 Gold test
ClosedPublic

Authored by troyj on Dec 3 2019, 1:37 PM.

Reviewers

tejohnson

Commits

Summary

This test was failing on non-X86 targets because the gold invocation did not have the necessary -m flag.

LGTM

Everytime one of these gets fixed I suggest that a bot be added to catch them earlier. So I guess I will repeat that suggestion here =)

This revision is now accepted and ready to land.Dec 3 2019, 2:14 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

test/

tools/

gold/

X86/

2 lines

Context not available.
	; RUN: opt -module-summary %s -o %t.o	; RUN: opt -module-summary %s -o %t.o
	; RUN: opt -module-summary %p/Inputs/linkonce_odr_unnamed_addr.ll -o %t2.o	; RUN: opt -module-summary %p/Inputs/linkonce_odr_unnamed_addr.ll -o %t2.o
	; RUN: %gold -plugin %llvmshlibdir/LLVMgold%shlibext \	; RUN: %gold -plugin %llvmshlibdir/LLVMgold%shlibext \
		; RUN: -m elf_x86_64 \
	; RUN: --plugin-opt=save-temps \	; RUN: --plugin-opt=save-temps \
	; RUN: %t.o %t2.o -o %t3.o	; RUN: %t.o %t2.o -o %t3.o
	; RUN: llvm-dis %t.o.1.promote.bc -o - \| FileCheck %s	; RUN: llvm-dis %t.o.1.promote.bc -o - \| FileCheck %s
Context not available.
	; conservative and not auto hide.	; conservative and not auto hide.
	; RUN: llc %p/Inputs/linkonce_odr_unnamed_addr.ll -o %t2native.o -filetype=obj	; RUN: llc %p/Inputs/linkonce_odr_unnamed_addr.ll -o %t2native.o -filetype=obj
	; RUN: %gold -plugin %llvmshlibdir/LLVMgold%shlibext \	; RUN: %gold -plugin %llvmshlibdir/LLVMgold%shlibext \
		; RUN: -m elf_x86_64 \
	; RUN: --plugin-opt=save-temps \	; RUN: --plugin-opt=save-temps \
	; RUN: %t.o %t2native.o -o %t3.o	; RUN: %t.o %t2native.o -o %t3.o
	; RUN: llvm-dis %t.o.1.promote.bc -o - \| FileCheck %s --check-prefix=NOSUMMARY	; RUN: llvm-dis %t.o.1.promote.bc -o - \| FileCheck %s --check-prefix=NOSUMMARY
Context not available.