This is an archive of the discontinued LLVM Phabricator instance.

[Gold] Add missing target flag to X86 Gold test
ClosedPublic

Authored by troyj on Dec 3 2019, 1:37 PM.

Details

Summary

This test was failing on non-X86 targets because the gold invocation did not have the necessary -m flag.

Diff Detail

Event Timeline

troyj created this revision.Dec 3 2019, 1:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2019, 1:37 PM
tejohnson accepted this revision.Dec 3 2019, 2:14 PM

LGTM

Everytime one of these gets fixed I suggest that a bot be added to catch them earlier. So I guess I will repeat that suggestion here =)

This revision is now accepted and ready to land.Dec 3 2019, 2:14 PM
This revision was automatically updated to reflect the committed changes.