This is an archive of the discontinued LLVM Phabricator instance.

scudo: Call setCurrentTSD(nullptr) when bringing down the TSD registry in tests.
ClosedPublic

Authored by pcc on Nov 26 2019, 7:20 PM.

Details

Summary

Otherwise, we will hit a use-after-free when testing multiple instances of
the same allocator on the same thread. This only recently became a problem
with D70552 which caused us to run both ScudoCombinedTest.BasicCombined and
ScudoCombinedTest.ReleaseToOS on the unit tests' main thread.

Diff Detail

Event Timeline

pcc created this revision.Nov 26 2019, 7:20 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 26 2019, 7:21 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Build result: pass - 60329 tests passed, 0 failed and 732 were skipped.

Log files: console-log.txt, CMakeCache.txt

cryptoad accepted this revision.Nov 27 2019, 7:47 AM
This revision is now accepted and ready to land.Nov 27 2019, 7:47 AM
This revision was automatically updated to reflect the committed changes.