Use InitLLVM in clang-tidy

[MrTrillian]

Summary

Update clang-tidy to use InitLLVM, like several other llvm tools that were previously updated. On Windows, this allows clang-tidy to operate on arguments containing characters which cannot be represented in the system's ANSI code page such as filenames with Unicode characters.

Fixes bugzilla bug 43751

Patch by Tristan Labelle.

[MrTrillian]

This is my first LLVM submission! Please let me know if there's any part of the process I missed. Thanks :)

[MrTrillian]

Bug link: https://bugs.llvm.org/show_bug.cgi?id=43751 (not sure how to format it in the description)
See previous change introducing InitLLVM: https://reviews.llvm.org/D45602

[ruiu]

LGTM

[MrTrillian]

Thanks @ruiu ! Any further actions on my part required?

[ruiu]

Nope, if you have a commit access, can you commit this?

[MrTrillian]

I'm just a random guy popping in here for the first time, I doubt I have commit access :)

[ruiu]

Sure, let me submit this patch for you.

clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp

 ///  for details on setting it up with LLVM source tree.
 ///
 //===----------------------------------------------------------------------===//
 
 #include "../ClangTidy.h"
 #include "../ClangTidyForceLinker.h"
 #include "../GlobList.h"
 #include "clang/Tooling/CommonOptionsParser.h"
+#include "llvm/Support/InitLLVM.h"
 #include "llvm/Support/Process.h"
 #include "llvm/Support/Signals.h"
 #include "llvm/Support/TargetSelect.h"
 
 using namespace clang::ast_matchers;
 using namespace clang::driver;
 using namespace clang::tooling;
 using namespace llvm;
if (!FS) {
     llvm::errs() << "Error: invalid virtual filesystem overlay file '"
                  << OverlayFile << "'.\n";
     return nullptr;
   }
   return FS;
 }
 
 static int clangTidyMain(int argc, const char **argv) {
-  llvm::sys::PrintStackTraceOnErrorSignal(argv[0]);
+  llvm::InitLLVM X(argc, argv);
   CommonOptionsParser OptionsParser(argc, argv, ClangTidyCategory,
                                     cl::ZeroOrMore);
   llvm::IntrusiveRefCntPtr<vfs::OverlayFileSystem> BaseFS(
       new vfs::OverlayFileSystem(vfs::getRealFileSystem()));
 
   if (!VfsOverlay.empty()) {
     IntrusiveRefCntPtr<vfs::FileSystem> VfsFromFile =
         getVfsFromFile(VfsOverlay, BaseFS);