Page MenuHomePhabricator

[clang-format] update string comparison in clang-format.py
ClosedPublic

Authored by pseyfert on Nov 25 2019, 4:05 AM.

Details

Summary

Python 3.8 introduces a SyntaxWarning about string comparisons with 'is'. This commit updates the string comparison in clang-format.py that is done with 'is not' to '!='. This should not break compatibility with older python versions (tested 3.4.9, 2.7.17, 2.7.5, 3.8.0).

Diff Detail

Event Timeline

pseyfert created this revision.Nov 25 2019, 4:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 25 2019, 4:05 AM
This revision is now accepted and ready to land.Nov 25 2019, 4:29 AM
MyDeveloperDay accepted this revision.Nov 25 2019, 5:06 AM

PS: I do not have commit access, so someone with the rights would need to land this for me. Thanks in advance.

MyDeveloperDay retitled this revision from update string comparison in clang-format.py to [clang-format] update string comparison in clang-format.py.Dec 6 2019, 9:37 AM
This revision was automatically updated to reflect the committed changes.