This is an archive of the discontinued LLVM Phabricator instance.

[JumpThreading] NFC: Don't cache F.hasProfileData()
ClosedPublic

Authored by kazu on Nov 22 2019, 8:51 AM.

Details

Summary

With this patch, we no longer cache F.hasProfileData(). We simply
call the function again.

I'm doing this because:

  • JumpThreadingPass also has a member variable named HasProfileData, which is very confusing,
  • the function is very lightweight, and
  • this patch makes JumpThreading::runOnFunction more consistent with JumpThreadingPass::run.

Diff Detail

Event Timeline

kazu created this revision.Nov 22 2019, 8:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2019, 8:51 AM
Herald added subscribers: jfb, hiraditya. · View Herald Transcript
kazu accepted this revision.Nov 22 2019, 8:51 AM

Self-LGTM as this is a very simple NFC.

This revision is now accepted and ready to land.Nov 22 2019, 8:51 AM
This revision was automatically updated to reflect the committed changes.