This is an archive of the discontinued LLVM Phabricator instance.

UpdateSDKDirectoryInfosInNeeded(); called twice, is that right?
ClosedPublic

Authored by vharron on Jan 19 2015, 8:35 AM.

Reviewers

clayborg

vharron retitled this revision from to UpdateSDKDirectoryInfosInNeeded(); called twice, is that right?.

vharron updated this object.

vharron edited the test plan for this revision. (Show Details)

vharron added a reviewer: clayborg.

vharron set the repository for this revision to rL LLVM.

vharron added a subscriber: Unknown Object (MLST).

Presumably that should be IfNeeded as well?

Please fix our typo from UpdateSDKDirectoryInfosInNeeded to UpdateSDKDirectoryInfosIsNeeded and commit.

This revision is now accepted and ready to land.Jan 19 2015, 11:39 AM

Committed revision 226957

Path

Size

	tsc/	lldb/	source/	Plugins/	Platform/	MacOSX/
	tot/	lldb/	source/	Plugins/	Platform/	MacOSX/

2 lines

Context not available.
	if (platform_file.GetPath(platform_file_path, sizeof(platform_file_path)))	if (platform_file.GetPath(platform_file_path, sizeof(platform_file_path)))
	{	{
	ModuleSpec platform_module_spec(module_spec);	ModuleSpec platform_module_spec(module_spec);
	UpdateSDKDirectoryInfosInNeeded();	UpdateSDKDirectoryInfosInNeeded();

	UpdateSDKDirectoryInfosInNeeded();

	const uint32_t num_sdk_infos = m_sdk_directory_infos.size();	const uint32_t num_sdk_infos = m_sdk_directory_infos.size();

	// If we are connected we migth be able to correctly deduce the SDK directory	// If we are connected we migth be able to correctly deduce the SDK directory
	// using the OS build.	// using the OS build.
	const uint32_t connected_sdk_idx = GetConnectedSDKIndex ();	const uint32_t connected_sdk_idx = GetConnectedSDKIndex ();
Context not available.