This is an archive of the discontinued LLVM Phabricator instance.

[LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope
ClosedPublic

Authored by aganea on Nov 19 2019, 8:57 AM.

Details

Summary

This fixes a warning on MSVC:

F:\llvm-project\lldb\source\Commands\CommandObjectThread.cpp(529): warning C4305: 'argument': truncation from 'char' to 'bool'

Previously, 'C' was passed into the wrong parameter, as is_class was introduced in D68671:

OptionGroupPythonClassWithDict(const char *class_use,
                               bool is_class = true,
                               int class_option = 'C',

Diff Detail

Event Timeline

aganea created this revision.Nov 19 2019, 8:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 19 2019, 8:57 AM
shafik added a subscriber: shafik.Nov 19 2019, 9:27 AM
shafik added inline comments.
lldb/source/Commands/CommandObjectThread.cpp
529

We could also leave out both true and C since both are already defaulted to these values.

aganea updated this revision to Diff 230097.Nov 19 2019, 10:02 AM
aganea marked an inline comment as done.

Omit default arguments.

This is a trivial change, unless you have any objections, I'll go forward with this.

jingham accepted this revision.Nov 21 2019, 10:35 AM

Looks right, thanks for catching this.

This revision is now accepted and ready to land.Nov 21 2019, 10:35 AM
This revision was automatically updated to reflect the committed changes.